Skip to content

Conversation

@amzhao16
Copy link
Collaborator

@amzhao16 amzhao16 commented Apr 8, 2025

Pull request to get make docs/lint/test working

Copy link
Contributor

@sarahmish sarahmish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I just made one note about __init__ file if you'd like to keep the imports clean!

Thanks @amzhao16!

__email__ = '[email protected]'
__version__ = '0.1.0.dev1'

from pygridsim.core import PyGridSim as PyGridSim
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need this if you would like to keep from pygridsim import PyGridSim. To overcome lint complaints, you can do the following:

from pygridsim.core import PyGridSim

__all__ = ('PyGridSim')

Then the "unused" imports will no longer be an error.

@amzhao16 amzhao16 merged commit 205b4b4 into main Apr 9, 2025
36 checks passed
@amzhao16 amzhao16 self-assigned this Apr 28, 2025
@amzhao16 amzhao16 added the bug Something isn't working label Apr 28, 2025
@amzhao16 amzhao16 added this to the 0.1.0 milestone Apr 28, 2025
@sarahmish sarahmish changed the title Test Pass Github Actions May 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants