-
Notifications
You must be signed in to change notification settings - Fork 0
Pass Github Actions #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
merges main into new branch
sarahmish
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I just made one note about __init__ file if you'd like to keep the imports clean!
Thanks @amzhao16!
| __email__ = '[email protected]' | ||
| __version__ = '0.1.0.dev1' | ||
|
|
||
| from pygridsim.core import PyGridSim as PyGridSim |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you need this if you would like to keep from pygridsim import PyGridSim. To overcome lint complaints, you can do the following:
from pygridsim.core import PyGridSim
__all__ = ('PyGridSim')Then the "unused" imports will no longer be an error.
Pull request to get make docs/lint/test working