Skip to content

Conversation

@amzhao16
Copy link
Collaborator

@amzhao16 amzhao16 commented Apr 9, 2025

This PR is a couple things combined, but mostly correctness issues that I noticed while writing:

  1. plurality consistency - because I do add_load_nodes it makes sense to keep plurality with add_generators
  2. update default values for industrial load (based on ieee13 standards, i think i just had an updated placeholder before)
  3. remove customization of Conns: doesn't match the type of (str, int) that all other customizations do, and also wouldn't make sense as is (user would have to internally poke the Connections class?)
  4. add missing customization tests for generators/pv systems/transformers

@amzhao16 amzhao16 requested a review from sarahmish April 9, 2025 18:17
@@ -1,5 +1,6 @@
# Byte-compiled / optimized / DLL files
__pycache__/
sim.json
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since sim.json is part of the repository, I would not include it in the .gitignore. there is a potential that sim.json would be changed in the future.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sim.json changes each time I run the test cases, because of the randomness assigned to them - I'll rewrite the test case so it doesn't change each time

@amzhao16 amzhao16 requested a review from sarahmish April 10, 2025 14:24
@amzhao16 amzhao16 merged commit 50dd804 into main Apr 11, 2025
36 checks passed
@amzhao16 amzhao16 self-assigned this Apr 28, 2025
@amzhao16 amzhao16 added the bug Something isn't working label Apr 28, 2025
@amzhao16 amzhao16 added this to the 0.1.0 milestone Apr 28, 2025
@sarahmish sarahmish changed the title Miscellaneous Corrections Add Naming Consistency, Customization Tests May 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants