Skip to content

Conversation

@amzhao16
Copy link
Collaborator

Previously: the results allowed for voltages (list of voltages), losses (dictionary of active power loss, reactive power loss) and totalpower (just kept active power, reactive power in an unreadable vector).

In this PR:

  • fixed totalpower to more clearly print out what is active power vs reactive power
  • no longer case-sensitive or space-sensitive
  • Users can also query the parts of losses or totalpower separately if they choose to.
  • i.e. if they just care about real power and losses they can have their query be ["RealPower", "RealLoss"], instead of having to query losses and totalpower and manually parse the results for the "real" parts

@amzhao16 amzhao16 requested a review from sarahmish April 10, 2025 14:58
@amzhao16 amzhao16 changed the base branch from main to misc-corrections April 10, 2025 15:04
@amzhao16 amzhao16 requested a review from Chrisschmit April 15, 2025 15:36
Copy link
Contributor

@sarahmish sarahmish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! @amzhao16

@amzhao16 amzhao16 merged commit a6ab569 into misc-corrections Apr 16, 2025
18 checks passed
@amzhao16 amzhao16 self-assigned this Apr 28, 2025
@amzhao16 amzhao16 added the enhancement New feature or request label Apr 28, 2025
@amzhao16 amzhao16 added this to the 0.1.0 milestone Apr 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants