-
Notifications
You must be signed in to change notification settings - Fork 0
[feat] 솜커톤 API GitHub & 포트폴리오 링크 추가 #105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
10e7189
[hotfix] 조직도 API 코드 수정
si-zero 0c2e084
hotfix: 조직도에 setter 추가
dohy-eon 2ec7fb6
hotfix: setter 임포트문 추가
dohy-eon ab66613
fix: 코드 수정
si-zero 4a29327
test: 솜커톤 참가자 생성, 조회, 삭제 기능 테스트
jucheonsu af60e14
feat: 솜커톤 참가자 GitHub/포트폴리오 링크 추가
jucheonsu 6e65595
refactor: 깃허브 링크 필수 제약 조건 제거
jucheonsu 5616eef
test: 솜커톤 참가자 CRUD 테스트
jucheonsu 1052852
refactor: 솜커톤 참가자 관련 리팩토링
jucheonsu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -42,3 +42,7 @@ out/ | |
| ### dev ### | ||
| application-dev.yml | ||
|
|
||
| # local/dev only | ||
| .dev/ | ||
| docker-compose.yml | ||
| init-user.sql | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,40 +5,53 @@ | |
| import jakarta.validation.constraints.NotBlank; | ||
| import jakarta.validation.constraints.Pattern; | ||
| import jakarta.validation.constraints.Size; | ||
| import lombok.AllArgsConstructor; | ||
| import lombok.Builder; | ||
| import lombok.Getter; | ||
| import lombok.Setter; | ||
| import org.hibernate.validator.constraints.URL; | ||
|
|
||
| @Getter | ||
| @Setter | ||
| @Builder | ||
| @AllArgsConstructor | ||
| @Schema(description = "솜커톤 참가자 요청 DTO") | ||
| public class SomParticipantRequestDto { | ||
|
|
||
| @NotBlank(message = "참가자 이름은 필수 입력 값입니다.") | ||
| @Size(max = 50, message = "참가자 이름은 최대 50자까지 입력 가능합니다.") | ||
| @Schema(description = "참가자 이름", example = "유승완", required = true) | ||
| private String participantName; // 참가자 이름 | ||
| private final String participantName; // 참가자 이름 | ||
|
|
||
| @NotBlank(message = "학번은 필수 입력 값입니다.") | ||
| @Pattern(regexp = "^[0-9]{8}$", message = "학번은 8자리 숫자여야 합니다.") | ||
| @Schema(description = "학번 (8자리 숫자)", example = "20250001", required = true) | ||
| private String studentId; | ||
| private final String studentId; | ||
|
|
||
| @NotBlank(message = "학과는 필수 입력 값입니다.") | ||
| @Size(max = 100, message = "학과는 최대 100자까지 입력 가능합니다.") | ||
| @Schema(description = "학과", example = "컴퓨터소프트웨어공학과", required = true) | ||
| private String department; // 학과 | ||
| private final String department; // 학과 | ||
|
|
||
| @NotBlank(message = "학년은 필수 입력 값입니다.") | ||
| @Pattern(regexp = "^[1-4]$", message = "학년은 1~4 사이의 숫자여야 합니다.") | ||
| @Schema(description = "학년 (1~4)", example = "3", required = true) | ||
| private String grade; // 학년 | ||
| private final String grade; // 학년 | ||
|
|
||
| @NotBlank(message = "연락처는 필수 입력 값입니다.") | ||
| @Pattern(regexp = "^010-[0-9]{4}-[0-9]{4}$", message = "연락처는 '010-XXXX-XXXX' 형식이어야 합니다.") | ||
| @Schema(description = "연락처 (010-XXXX-XXXX 형식)", example = "010-1234-5678", required = true) | ||
| private String contact; // 연락처 | ||
| private final String contact; // 연락처 | ||
|
|
||
| @NotBlank(message = "이메일은 필수 입력 값입니다.") | ||
| @Email(message = "올바른 이메일 형식이 아닙니다.") | ||
| @Schema(description = "이메일 주소", example = "[email protected]", required = true) | ||
| private String email; // 이메일 | ||
| private final String email; // 이메일 | ||
|
|
||
| @URL(protocol = "https", host = "github.com", message = "GitHub URL이 올바르지 않습니다.") | ||
| @Schema(description = "GitHub 주소", example = "https://github.com/username") | ||
| private final String githubLink; // 깃허브 주소 | ||
|
|
||
| @NotBlank(message = "포트폴리오 주소는 필수 입력 값입니다.") | ||
| @URL(protocol = "https", message = "포트폴리오 URL이 올바르지 않습니다.") | ||
| @Schema(description = "포트폴리오 주소", example = "https://portfolio.com/username", required = true) | ||
| private final String portfolioLink; // 포트폴리오 주소 | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -31,4 +31,10 @@ public class SomParticipantResponseDto { | |
|
|
||
| @Schema(description = "이메일 주소", example = "[email protected]", required = true) | ||
| private String email; // 이메일 | ||
| } | ||
|
|
||
| @Schema(description = "깃허브 주소", example = "https://github.com/username", required = true) | ||
| private String githubLink; // 깃허브 주소 | ||
|
|
||
| @Schema(description = "포트폴리오 주소", example = "https://portfolio.com/username", required = true) | ||
| private String portfolioLink; // 포트폴리오 주소 | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 이 부분을 서비스단에서 처리하는게 아니라 엔티티 단계에서 처리하도록 수정해주세요! There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 넵 리뷰 감사합니다! 수정 완료했습니다! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SomParticipantService.toResponseDto() 로직을 여기 하단에 추가해주심 됩니다. 엔티티 캡슐화나 책임 분리? 라는 내용으로 찾아보심 될 것 같아요
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
넵 리뷰 감사합니다! 수정 완료했습니다!