Release v1.0.2 #74
Merged
Release v1.0.2 #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: 면접 예약 API 면접 일정 조회시 status도 같이 반환 * fix: 면접 예약 API 예약자 명단 조회 API 추가 * fix: 면접 예약 API 예약되어있는 슬롯은 삭제하지 않는 기능 추가 * fix: 면접 예약자 조회 API 면접일, 면접시간, 면접을 예약한 날짜과 시간 추가 * feat: 솜커톤 참가자 모집 API 생성 * feat: 솜커톤 참가자 모집 API 요청 URL에 somkathon 추가 * fix: 솜커톤 참가자 모집 API comment 해결 * fix: 솜커톤 참가자 모집 API comment 해결
|
|
||
| public SomParticipantResponseDto updateParticipant(Long id, SomParticipantRequestDto requestDto){ | ||
| SomParticipant participant = findParticipantById(id); | ||
|
|
There was a problem hiding this comment.
The updateParticipant method does not validate for duplicate studentId, which may lead to conflicts if the studentId is modified. Consider adding a duplicate check similar to createParticipant before applying updates.
Suggested change
| if (!participant.getStudentId().equals(requestDto.getStudentId())) { | |
| validateDuplicatedStudentId(requestDto.getStudentId()); | |
| } |
ysw789
approved these changes
Apr 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release v1.0.2
변경 내용