- 
                Notifications
    
You must be signed in to change notification settings  - Fork 0
 
[refactor] 이메일 발송 비동기식으로 전환 #91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
        
          
                src/main/java/dmu/dasom/api/domain/google/service/EmailService.java
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                src/main/java/dmu/dasom/api/domain/google/service/EmailService.java
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                src/main/java/dmu/dasom/api/domain/google/service/EmailService.java
              
                Outdated
          
            Show resolved
            Hide resolved
        
      There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고 많으셨습니다!
지금 getSubject, getEmailContent, getButtonText 메서드 전부 다 switch문인데 enum 파서 처리하는게 훨씬 가독성도 올라가고 유지보수가 쉬워질 것 같습니다.
[ 권장 수정 방안 ]
public enum MailTemplate {
    DOCUMENT_RESULT("동양미래대 서류 결과 안내", "서류 결과 확인하기"),
    FINAL_RESULT("동양미래대 최종 결과 안내", "최종 결과 확인하기");
    private final String subject;
    private final String buttonText;
    + emailContent까지
}
- 추가로 제안사항인데 이전 기수 모집 때 이메일 발송오류 처리때문에 잠깐 혼란이 있었었는데 백에서 로그 테이블 따로 파서 전송 대상 이메일이랑 실패 사유 같은거 정리하면 좋지 않을까? 라는 생각이 있었습니다,, 고려해주시면 감사하겠습니다.
 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
확인했습니다!
[refactor] 이메일 발송 비동기식으로 전환
Issue
변경 내용
체크리스트
테스트