- 
                Notifications
    
You must be signed in to change notification settings  - Fork 0
 
[feat] 조직도 API 추가 #92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
        
          
                src/main/java/dmu/dasom/api/domain/executive/controller/ExecutiveContorller.java
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                src/main/java/dmu/dasom/api/domain/executive/service/ExecutiveService.java
              
                Outdated
          
            Show resolved
            Hide resolved
        
      | 
           작업하느라 고생 많으셨습니다! 부가적인 리뷰 남겨드리겠습니다. 
  | 
    
| 
           에러 코드를 enum은   | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고 많으셨습니다! 아래에 개선방안 몇가지만 작성해두겠습니다!
- 
컨트롤러 스펠링 오탈자 수정
ExecutiveContorller -> ExecutiveController - 
예외처리
기존IllegalArgumentException("Executive not found") 
[ 권장 수정 방안 ]
.orElseThrow(() -> new CustomException(ErrorCode.EXECUTIVE_NOT_FOUND));
ErrorCode에 EXECUTIVE_NOT_FOUND(HttpStatus.NOT_FOUND, "임원진을 찾을 수 없습니다.");
추가 후 사용
추가로 테스트 코드에 성공 케이스만 존재하던데 실패 케이스도 추가하면 좋을 것 같습니다!
고생하셨습니다 
        
          
                src/main/java/dmu/dasom/api/domain/executive/dto/ExecutiveRequestDto.java
          
            Show resolved
            Hide resolved
        
              
          
                src/main/java/dmu/dasom/api/domain/executive/service/ExecutiveService.java
          
            Show resolved
            Hide resolved
        
              
          
                src/main/java/dmu/dasom/api/domain/executive/dto/ExecutiveCreationResponseDto.java
          
            Show resolved
            Hide resolved
        
      82d1f47    to
    3375bcc      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
확인했습니당
Issue
변경 내용
테스트
리뷰 요구사항