Skip to content

[Refactor] 로그인 로직 분리 #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 30, 2025
Merged

[Refactor] 로그인 로직 분리 #94

merged 2 commits into from
Aug 30, 2025

Conversation

@NADELYSS
Copy link
Contributor

@NADELYSS NADELYSS commented Aug 21, 2025 •
edited
Loading

[refactor] 로그인 로직 분리

Issue

변경 내용

  • 로그인 로직 spring security에서 분리하여 MemberController에 추가

체크리스트

  • 커밋 메시지가 컨벤션을 따르는가?
  • 린트 검사를 통과했는가? (npm run lint or npm run lint:fix)
  • 로컬에서 빌드가 성공하는가? (npm run build)

테스트

  • 로컬에서 테스트 완료
  • 기존 기능에 영향 없음 확인
  • 다양한 브라우저에서 테스트

리뷰 요구사항

  • 현재 admin 역할 부여를 db에서 처리중, 이를 api로 처리하게 해주는 기능을 넣어야하는지 검토 요청

@NADELYSS NADELYSS requested review from hodoon and ysw789 August 21, 2025 15:30
@NADELYSS NADELYSS self-assigned this Aug 22, 2025
@NADELYSS NADELYSS changed the base branch from main to dev August 23, 2025 14:04
@NADELYSS NADELYSS force-pushed the DASOMBE-17-refactor-로그인-로직-분리 branch from 19b3575 to e07eb79 Compare August 24, 2025 16:38
@NADELYSS NADELYSS changed the title Dasombe 17 refactor 로그인 로직 분리 [Refactor] 로그인 로직 분리 Aug 26, 2025
@hodoon hodoon merged commit 1069ff7 into dev Aug 30, 2025
1 check passed
@hodoon hodoon deleted the DASOMBE-17-refactor-로그인-로직-분리 branch August 30, 2025 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hodoon hodoon hodoon approved these changes

@ysw789 ysw789 Awaiting requested review from ysw789

Assignees

@NADELYSS NADELYSS

Labels

REFACTOR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@NADELYSS @hodoon