Conversation
| #include "ChucKListenerCHOP.h" | ||
| #include "Plugin_ChucK.h" | ||
|
|
||
| #include <algorithm> |
There was a problem hiding this comment.
It was necessary for me to build successfully on Windows using Python 3.11.
| chugin_search.push_back(globalDir + "/chugins" ); | ||
|
|
||
| chuck->setParam( CHUCK_PARAM_USER_CHUGIN_DIRECTORIES, chugin_search ); | ||
| chuck->setParam( CHUCK_PARAM_IMPORT_PATH_SYSTEM, chugin_search ); |
There was a problem hiding this comment.
It seems like it should be CHUCK_PARAM_CHUGIN_LIST_USER_DIR https://github.com/ccrma/chuck/blob/28a3d5fe3182ade782ca774c4161359a74bf126d/VERSIONS#L665
There was a problem hiding this comment.
That was my first thought as well, but seems like that variable was renamed somewhere in between 1.5.3.0 and 1.5.5.2. See below:
https://github.com/ccrma/chuck/blob/29d801d72ddc604a4590566cd6a16e3ee1f7577c/src/core/chuck.cpp#L708
and
https://github.com/ccrma/chuck/blob/e67c82e9081fc7490beaa494dc7a235fc0d1220e/src/core/chuck.cpp#L727
There was a problem hiding this comment.
Interesting. I asked on the #bug-reports Discord. It's probably just a mistake in VERSIONS.
|
Thanks! It looks like I should update the macOS GitHub actions. Don't worry about that, but can you address the two comments? It would be helpful to hear if you're testing it with chugins. |
Replied to both comments. Note that I am building on Windows with Python 3.11, I don't have a macos device to test on there. I haven't tested chugins yet. |
2 participants
Updated ChucK to 1.5.5.2. Two key fixes:
CHUCK_PARAM_USER_CHUGIN_DIRECTORIESrenamed toCHUCK_PARAM_IMPORT_PATH_SYSTEMinsrc/Plugin_ChucK.cppAdded
#include <algorithm>insrc/ChucKListenerCHOP.cpp