fix: ValueError when removing activated datasets and opening Quick View

Author: paulmueller

CHANGELOG

@@ -3,6 +3,7 @@
  - fix: ValueError when filtering all events in Quick View (#37)
  - fix: TypeError when removing datasets and opening Quick View (#38)
  - fix: RuntimeError when removing datasets and opening Quick View (#38)
+ - fix: ValueError when removing activated datasets and opening Quick View
 2.0.1
  - fix: correctly distinguish prereleases when checking for new versions
  - enh: allow loading data via drag&drop

shapeout2/gui/quick_view/qv_main.py

@@ -178,6 +178,18 @@ def __setstate__(self, state):
             self.checkBox_trace_raw.setChecked(event["trace raw"])
             self.checkBox_trace_legend.setChecked(event["trace legend"])
 
+    def _check_file_open(self, rtdc_ds):
+        """Check whether a dataset is still open"""
+        if isinstance(rtdc_ds, dclab.rtdc_dataset.RTDC_HDF5):
+            if rtdc_ds._h5:
+                # the file is open
+                isopen = True
+            else:
+                isopen = False
+        elif isinstance(rtdc_ds, dclab.rtdc_dataset.RTDC_Hierarchy):
+            isopen = self._check_file_open(rtdc_ds.hparent)
+        return isopen
+
     def _set_initial_ui(self):
         # Initially, only show the info about how QuickView works
         self.widget_tool.setEnabled(False)
@@ -193,10 +205,8 @@ def _set_initial_ui(self):
     def rtdc_ds(self):
         """Dataset to plot; set to None initially and if the file is closed"""
         if self._rtdc_ds is not None:
-            if isinstance(self._rtdc_ds, dclab.rtdc_dataset.RTDC_HDF5):
-                if not self._rtdc_ds._h5:
-                    # the file is closed
-                    self._rtdc_ds = None
+            if not self._check_file_open(self._rtdc_ds):
+                self._rtdc_ds = None
         # now check again
         if self._rtdc_ds is None:
             self._set_initial_ui()

tests/test_gui_quickview.py

@@ -103,6 +103,57 @@ def test_no_events_issue_37(qtbot):
     mw.close()
 
 
+def test_remove_dataset_h5py_error(qtbot):
+    """Removing an activated dataset and activating Quick View fails
+
+    Unhandled exception in Shape-Out version 2.0.1.post2:
+    Traceback (most recent call last):
+      File "/home/paul/repos/ShapeOut2/shapeout2/gui/main.py", line 235,
+        in adopt_pipeline
+        self.widget_quick_view.update_feature_choices()
+      File "/home/paul/repos/ShapeOut2/shapeout2/gui/quick_view/qv_main.py",
+        line 635, in update_feature_choices
+        ds_feats = [f for f in self.rtdc_ds.features if f in feats_scalar]
+    [...]
+      File "/home/paul/repos/dclab/dclab/rtdc_dataset/fmt_hdf5.py", line 101,
+        in _is_defective_feature
+        if attr in self._h5.attrs:
+    [...]
+      File "h5py/_objects.pyx", line 55, in h5py._objects.with_phil.wrapper
+      File "h5py/h5o.pyx", line 190, in h5py.h5o.open
+    ValueError: Not a location (invalid object ID)
+    """
+    mw = ShapeOut2()
+    qtbot.addWidget(mw)
+
+    # add a dataslot
+    path = pathlib.Path(__file__).parent / "data" / "calibration_beads_47.rtdc"
+    mw.add_dataslot(paths=[path, path])
+
+    assert len(mw.pipeline.slot_ids) == 2, "we added those"
+    assert len(mw.pipeline.filter_ids) == 1, "automatically added"
+
+    # activate a dataslot
+    slot_id = mw.pipeline.slot_ids[0]
+    filt_id = mw.pipeline.filter_ids[0]
+    em = mw.block_matrix.get_widget(slot_id, filt_id)
+    qtbot.mouseClick(em, QtCore.Qt.LeftButton)  # activate
+    qtbot.mouseClick(em, QtCore.Qt.LeftButton, QtCore.Qt.ShiftModifier)
+    # did that work?
+    assert mw.pipeline.is_element_active(slot_id, filt_id)
+
+    # close Quick View
+    qtbot.mouseClick(mw.toolButton_quick_view, QtCore.Qt.LeftButton)
+
+    # now remove the dataset
+    pw = mw.block_matrix.get_widget(slot_id=slot_id)
+    pw.action_remove()
+
+    # open Quick View
+    qtbot.mouseClick(mw.toolButton_quick_view, QtCore.Qt.LeftButton)
+    mw.close()
+
+
 def test_update_polygon_filter_issue_26(qtbot):
     """https://github.com/ZELLMECHANIK-DRESDEN/ShapeOut2/issues/26