C-130J: ARC-210 #1526
C-130J: ARC-210 #1526
Conversation
| C_130J:definePushButton("ARC210_LSK_1", devices.VOLUME_MANAGER, 3145, 550, ARC_210, "ARC-210 LSK 1") | ||
| C_130J:definePushButton("ARC210_LSK_2", devices.VOLUME_MANAGER, 3146, 549, ARC_210, "ARC-210 LSK 2") | ||
| C_130J:definePushButton("ARC210_LSK_3", devices.VOLUME_MANAGER, 3147, 548, ARC_210, "ARC-210 LSK 3") | ||
| C_130J:defineTumb("ARC210_SQUELCH_SWITCH", devices.VOLUME_MANAGER, 3159, 532, 2, { -1, 1 }, nil, false, ARC_210, "ARC-210 Squelch Switch") |
There was a problem hiding this comment.
It looks to me like this is a standard 0-1, so defineToggleSwitch. I suspect it won't turn off because it's trying to set the value to -1, which isn't possible for this control.
There was a problem hiding this comment.
Ok with this only set_state is working, rest fixed_step and action not:
C_130J:defineToggleSwitch("ARC210_SQUELCH_SWITCH", devices.VOLUME_MANAGER, 3159, 532, ARC_210, "ARC-210 Squelch Switch")I compare different usages of multiswitch() from DCS to corresponding BIOS counterparts. ARC210_SQUELCH_SWITCH is oddball, looks like it need two position but with step set to 2, but this one is working:
C_130J:defineMultipositionSwitch("ARC210_SQUELCH_SWITCH", devices.VOLUME_MANAGER, 3159, 532, 2, 2, ARC_210, "ARC-210 Squelch Switch")Please check it out.
There was a problem hiding this comment.
Checked the C-130 luas - it does look like this is a -1 to 1 toggle switch yeah. Does it work with defineTumb? You could also use defineToggleSwitchManualRange, which would be a little bit cleaner imo:
C_130J:defineToggleSwitchManualRange("ARC210_SQUELCH_SWITCH", devices.VOLUME_MANAGER, 3159, 532, { -1, 1 }, ARC_210, "ARC-210 Squelch Switch")
|
It looks like you merged main into your branch, which is not ideal for this PR. Is there something from main that you need on this branch? |
yeah, it should be |
|
@charliefoxtwo fixed |
2 participants
Fixes: #1481
Only one problem with
ARC210_SQUELCH_SWITCHwhen I increase in Bort I can't decrease it.