FA-18: fix Emergency and Parking brake command not working with RS485

[eHanseJoerg]

This FIX adds two additional, shortened commands to FA-18C_hornet.lua for the Emergency and Parking brake

It reduces command length of the ROTATE command below 32 bytes, therefore correcting the bug that this command won't work under the current RS485 implementation used by DCS-BIOS Arduino library.

Because it just adds two lines instead of changing the lines, the change is fully backwards compatible.

Tested and confirmed working in my simpit.

[charliefoxtwo]

So I have a couple concerns with this:

1. These lines are added to the middle of the file, which will change all addresses after these lines, which would not be backwards compatible (you can see this in the Addresses.h file, which should be included with the PR)
2. I'm hesitant to accept this and set a precedent that we'll allow hacks for random controls, when the core issue is that sendDcsBiosMessage fails via RS485 if message is too long dcs-bios-arduino-library#91 needs to be fixed (unfortunately, I don't have the expertise to fix that issue).

Perhaps someone in the skunkworks discord has the requisite knowledge to help fix that issue? We've also been looking for a new maintainer for the arduino library but have yet to find one unfortunately.

[eHanseJoerg]

Thanks for checking the code! Yes after testing again I can confirm that the subsequent addresses need to be changed, which would cause a high workload for many users not using addresses.h .

Options going forward

1. Move the two lines to the very end of the file and accept that it is a "hacky" solution. This should as far as I understand it now avoid address shifts for the other commands. Given that the rest of the file also does not look finished (e.g. the TODOs and comments in the code) this might be justifiable. Disadvantage: its hacky.

2. File a PR in the Arduino library that sets the RingBuffer to 64 (we know how to do that and have tested it). Disadvantage: we do not know when this will, if ever, be merged

3. Accept this PR as a temp solution and still file the PR for the Arduino library as the final solution.

[charliefoxtwo]

Just to clarify, even if a user is using Addresses.h, they would still have to recompile their sketch when updating bios, which is not desirable (I know you've fixed the issue, just providing more context about the effects for future reference).

As far as the file not being "finished" goes - I'm not sure what you're referring to, but the hornet has been out for a while and should definitely be complete. There could be one or two minor items that need investigation or have no clearppath forward (e.g. The LTD/R switch has been a common source of confusion) but for all intents and purposes the module is "complete" and I'm not aware of any missing functionality.

Regarding option 2, if someone submits a PR and a couple people from the community can weigh in asserting it has been tested, I can merge it.