Conversation
Before parsing each key, verify that it still matches the seek prefix. This avoids iterating through keys that are lexicographically close but cannot match. This significantly improves performance for queries for non-existent prefixes that have many shorter prefix matches in the database.
fhonza
approved these changes
Jan 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This MR introduces the following changes:
blb_rocksdb_query_by_i()to break out of the iterator loop immediately when keys no longer match the seek prefix. This avoids unnecessary iteration and parsing of keys that are lexicographically close but cannot match-Wuse-after-freewarning by capturing the old pointer address asuintptr_tbefore callingrealloc(), then logging the integer value instead of the potentially-freed pointer.balboa-backend-console: add-loption to set query result limit as well as add documentation for thequerycommand in usage text