Follow-up: add hasNext to ScrollResponse and validate in scroll service tests

[IjjS]

Motivation

• Clients could not reliably detect last-page responses from cursor pagination because ScrollResponse lacked an explicit hasNext flag, causing duplicate/infinite fetches in some flows.
• The change centralizes the next-page semantics in the shared DTO so all services using ScrollResponse behave consistently.

Description

• Added boolean hasNext to the ScrollResponse record and set it in from(List<T>, String) as nextCursor != null to derive next-page semantics from existing cursor logic.
• Updated service tests that produce/consume ScrollResponse to assert hasNext semantics in paging scenarios for both pageable and last-page cases.
• Test files updated: DduduSearchServiceTest, AnnouncementSearchServiceTest, and NotificationInboxSearchServiceTest to include hasNext=true for pageable paths and hasNext=false for last-page/single-result cases.
• Kept nextCursor behavior unchanged and computed hasNext from it, minimizing changes to service implementation logic.

Testing

• Ran compile checks: ./gradlew :application:application-common:compileJava :application:notification-application:compileTestJava :application:planning-application:compileTestJava which completed successfully.
• Attempted targeted test execution with ./gradlew :application:planning-application:test --tests "*DduduSearchServiceTest" :application:notification-application:test --tests "*AnnouncementSearchServiceTest" --tests "*NotificationInboxSearchServiceTest" which ultimately failed in this environment due to test environment datasource/Bean creation issues and JaCoCo coverage verification failures.
• Verified that test source compilation for the affected modules succeeded with ./gradlew :application:notification-application:compileTestJava :application:planning-application:compileTestJava.

---

Codex Task

[github-actions]

📊 Jacoco Test Coverage

Overall Project	94.54%	🍏
Files changed	100%	🍏

File	Coverage
ScrollResponse.java	100%	🍏

[github-actions]

⚠️ [checkstyle] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> _{reported by reviewdog 🐶}
Line is longer than 100 characters (found 101).

[github-actions]

⚠️ [checkstyle] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> _{reported by reviewdog 🐶}
Line is longer than 100 characters (found 101).

[IjjS]

@codex 현재 PR에 github-actions bot이 남겨둔 checkstyle warning을 수정해봐

[chatgpt-codex-connector]

Summary

• Fixed the reviewdog checkstyle LineLengthCheck warnings by reformatting long service invocation lines into wrapped assignments in NotificationInboxSearchServiceTest (no behavior change). application/notification-application/src/test/java/com/ddudu/application/notification/inbox/NotificationInboxSearchServiceTest.javaL111-L113 application/notification-application/src/test/java/com/ddudu/application/notification/inbox/NotificationInboxSearchServiceTest.javaL141-L143 application/notification-application/src/test/java/com/ddudu/application/notification/inbox/NotificationInboxSearchServiceTest.javaL172-L174 application/notification-application/src/test/java/com/ddudu/application/notification/inbox/NotificationInboxSearchServiceTest.javaL192-L194
• Fixed the other flagged long line by wrapping NotificationInboxSearchRequest construction arguments in the last-page test case. application/notification-application/src/test/java/com/ddudu/application/notification/inbox/NotificationInboxSearchServiceTest.javaL210-L213
• Committed the change on the current branch (11494a22) and created a follow-up PR via the make_pr tool as requested.

Testing

• ✅ awk 'length($0)>100 {print NR ":" length($0)}' application/notification-application/src/test/java/com/ddudu/application/notification/inbox/NotificationInboxSearchServiceTest.java (no output; no lines exceed 100 chars)
• ⚠️ bash ./gradlew --no-daemon :application:notification-application:checkstyleTest --stacktrace (build started but did not finish within session time window)
• ⚠️ curl -I https://checkstyle.sourceforge.io/checks/sizes/linelength.html | head (web lookup attempt blocked by proxy 403)

View task →