Improved GSM performance #86
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Have you tested it, or are you confident in your abilities? :D |
Collaborator
Author
|
Nice that you ask that after merging. I did a little testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My measurement runs indicate that this reduces the runtime of GSM for RPNI by about 30%. I used the Abbadingo data as a benchmark. The main point was avoiding pythons
copywhile creating the partitions. Some other parts were improved. According to my profiling runs they should amount to about 5% or so, but the measurement runs without profiling are actually inconclusive. AFAIK there is no regression.