[lb] Fix site validation on GetCourseOptionFromCodes service#11685
Merged
[lb] Fix site validation on GetCourseOptionFromCodes service#11685
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
I'm really surprised this hasn't come up before -- This is a bug in the
GetCourseOptionFromCodesservice used when making an offer and changing courses from the API. But it was raised in Sandbox, support ticket.Changes proposed in this pull request
Call uniq, so courses with full and part-time options don't give false invalid errors.
Guidance to review
In sandbox
get_course_option_service.valid?will be false.This is because
But the same with
uniq.countis 1.Things to check