Add auditing to previous teacher training#11686
Merged
Conversation
Contributor
Review App DeletedThe review app for PR #11686 has been successfully removed. |
dp-daly
force-pushed
the
dpd/add-audits-to-ptt
branch
from
9604126 to
5225592
Compare
elceebee
reviewed
Feb 24, 2026
Comment on lines
7
to
11
| audited | ||
|
|
||
| has_associated_audits | ||
| audited associated_with: :application_form | ||
|
|
Collaborator
There was a problem hiding this comment.
I hadn't thought about this, but we probably don't want to audit drafts. We only want to audit changes to published (because that's what we'll do on the command line), and when it goes from draft -> published.
Collaborator
There was a problem hiding this comment.
(tbh, I'm not sure how possible that is to execute, let me know if this ends up being a blocker)
Contributor
Author
There was a problem hiding this comment.
ah no worries, I've managed it I think. If we make a change via the console it will track, but it won't track changes made by the candidate while it's still editable (given it sets the status back to draft):
dp-daly
force-pushed
the
dpd/add-audits-to-ptt
branch
from
9a8164f to
1580cdb
Compare
Contributor
Author
elceebee
approved these changes
Feb 25, 2026
Contributor
|
Review app for PR 11686 was deleted |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
When a previous teacher training is created, updated or destroyed there is no audit record created. This PR adds auditing to the model.
Changes proposed in this pull request
auditedandhas_associated_auditsto the modelGuidance to review
Screen.Recording.2026-02-25.at.08.33.00.mov
Things to check