Closed
Conversation
DfE::Analytics initialisation code was ignoring the "config.async = false" option when provided, and setting it to "config.async = true" anyways. This was caused by the conditional assignment operator "||=". "foo ||= true" does set 'foo' as 'true' if it was either 'nil' or 'false'.
Contributor
Author
|
Tests pass locally (at least on my setup!) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DfE::Analyticsinitialisation code ignored theconfig.async = falseoption when provided.This was caused by the conditional assignment operator
||=, asfoo ||= truedoes setfoo = trueif it was eithernilorfalse.Changed it to default to
trueonly if no explicit value was set.