Skip to content

Fix backwards compatibility for DfE::Analytics jobs used externally #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
asatwal merged 1 commit into from
Dec 3, 2025
Merged

Fix backwards compatibility for DfE::Analytics jobs used externally #219

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/dfe/analytics.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
require 'google/cloud/bigquery'
require 'dfe/analytics/activerecord' if defined?(ActiveRecord)
require 'dfe/analytics/jobs'
require 'dfe/analytics/analytics_job'
require 'dfe/analytics/entity_table_check_job'
require 'dfe/analytics/config'
require 'dfe/analytics/event_schema'
require 'dfe/analytics/fields'
Expand Down
5 changes: 5 additions & 0 deletions lib/dfe/analytics/analytics_job.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
module DfE
module Analytics
AnalyticsJob = DfE::Analytics::Jobs::AnalyticsJob
end
end
5 changes: 5 additions & 0 deletions lib/dfe/analytics/entity_table_check_job.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
module DfE
module Analytics
EntityTableCheckJob = DfE::Analytics::Jobs::EntityTableCheckJob
end
end
10 changes: 10 additions & 0 deletions spec/dfe/analytics_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,4 +385,14 @@
expect { DfE::Analytics.initialize! }.not_to raise_error
end
end

describe 'Backward compatibility constants for DfE::Analytics' do
it 'aliases DfE::Analytics::AnalyticsJob to DfE::Analytics::Jobs::AnalyticsJob' do
expect(DfE::Analytics::AnalyticsJob).to eq(DfE::Analytics::Jobs::AnalyticsJob)
end

it 'aliases DfE::Analytics::EntityTableCheckJob to DfE::Analytics::Jobs::EntityTableCheckJob' do
expect(DfE::Analytics::EntityTableCheckJob).to eq(DfE::Analytics::Jobs::EntityTableCheckJob)
end
end
end