Skip to content

feat: Enable azure AD auth only for mssql. #1137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Edboy15 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: Enable azure AD auth only for mssql. #1137

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions terraform/container-apps-hosting.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ module "azure_container_apps_hosting" {
mssql_server_public_access_enabled = local.mssql_server_public_access_enabled
mssql_managed_identity_assign_role = local.mssql_managed_identity_assign_role
mssql_sku_name = local.mssql_sku_name
mssql_azuread_auth_only = local.mssql_azuread_auth_only

mssql_private_endpoint_subnet_cidr = local.mssql_private_endpoint_subnet_cidr
storage_subnet_cidr = local.storage_subnet_cidr
Expand Down
1 change: 1 addition & 0 deletions terraform/locals.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ locals {
mssql_sku_name = var.mssql_sku_name
mssql_managed_identity_assign_role = var.mssql_managed_identity_assign_role
mssql_private_endpoint_subnet_cidr = var.mssql_private_endpoint_subnet_cidr
mssql_azuread_auth_only = var.mssql_azuread_auth_only
storage_subnet_cidr = var.storage_subnet_cidr
enable_dns_zone = var.enable_dns_zone
dns_zone_domain_name = var.dns_zone_domain_name
Expand Down
6 changes: 6 additions & 0 deletions terraform/variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,12 @@ variable "mssql_managed_identity_assign_role" {
default = false
}

variable "mssql_azuread_auth_only" {
description = "Set to true to only permit SQL logins from Azure AD users"
type = bool
default = false
}

variable "enable_cdn_frontdoor" {
description = "Enable Azure CDN FrontDoor. This will use the Container Apps endpoint as the origin."
type = bool
Expand Down
Loading