Report errors to Sentry even when jobs are retried #981
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has been around the houses a little recently in [sentry-ruby]: - [#2500] - [#2573] - [#2617] but the TLDR seems to be we should enable a configuration option `active_job_report_on_retry_error` if we want to report errors when jobs are retried in `ActiveJob`. This enables the configuration. We want to do this, because it gives us better observablity of when things are going wrong (e.g we're not sending OTP emails due to errors). [sentry-ruby]: https://github.com/getsentry/sentry-ruby [#2500]: getsentry/sentry-ruby#2500 [#2573]: getsentry/sentry-ruby#2573 [#2617]: getsentry/sentry-ruby#2617
|
|
Review app deployed to https://cpd-ec2-review-981-web.test.teacherservices.cloud |
Contributor
|
Sensible |
peterdavidhamilton
approved these changes
Jul 21, 2025
peteryates
approved these changes
Jul 23, 2025
leandroalemao
approved these changes
Jul 23, 2025
cpjmcquillan
deleted the
connor/1964-sentry-capture-retried-active-job-errors
branch
|
Review app for PR 981 was deleted |
cpjmcquillan
added a commit
that referenced
this pull request
Jul 23, 2025
In #981, I missed the `.rails`. We didn't catch it because Sentry is disabled in review apps, but it blew up on Staging. This fixes things. Verified locally with `ENABLE_SENTRY=true bin/dev` before/after the change.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
https://github.com/DFE-Digital/register-ects-project-board/issues/1964
Changes proposed in this pull request
This has been around the houses a little recently in sentry-ruby:
but the TLDR seems to be we should enable a configuration option
active_job_report_on_retry_errorif we want to report errors when jobs are retried inActiveJob.This enables the configuration.
We want to do this, because it gives us better observablity of when things are going wrong (e.g we're not sending OTP emails due to errors).
Guidance to review