Same refactor for JobPreferecnes Work.Pat. migration

Author: scruti

app/models/job_preferences.rb

@@ -29,4 +29,16 @@ def to_multistep
   def key_stages_for_phases
     phases.map { |phase| Vacancy::PHASES_TO_KEY_STAGES_MAPPINGS[phase.to_sym] }.flatten.uniq.sort
   end
+
+  def self.migrate_legacy_working_patterns
+    where.not(working_patterns: nil).find_each do |jp|
+      if jp.working_patterns.include?("term_time")
+        jp.assign_attributes(working_patterns: (jp.working_patterns - %w[term_time] + %w[full_time]).uniq)
+      end
+      if jp.working_patterns.include?("flexible")
+        jp.assign_attributes(working_patterns: (jp.working_patterns - %w[flexible] + %w[part_time]).uniq)
+      end
+      jp.save!(validate: false, touch: false)
+    end
+  end
 end

lib/tasks/data.rake

@@ -78,6 +78,13 @@ namespace :backfills do
   end
 end
 
+namespace :job_preferences do
+  desc "Migrate legacy working patterns"
+  task migrate_legacy_working_patterns: :environment do
+    JobPreferences.migrate_legacy_working_patterns
+  end
+end
+
 namespace :subscriptions do
   desc "Discard subscriptions that fail validation (probably due to invalid email address)"
   task discard_invalid: :environment do

lib/tasks/migrate_legacy_job_preferences.rake

@@ -40,4 +40,28 @@
       end
     end
   end
+
+  describe ".migrate_legacy_working_patterns" do
+    let!(:pref_a) { create(:job_preferences, working_patterns: %w[term_time flexible part_time]) }
+    let!(:pref_b) { create(:job_preferences, working_patterns: %w[flexible full_time]) }
+    let!(:pref_c) { create(:job_preferences, working_patterns: %w[term_time]) }
+
+    before do
+      create(:job_preferences)
+      create(:job_preferences, working_patterns: nil)
+      described_class.migrate_legacy_working_patterns
+    end
+
+    it "fixes up term time flexible" do
+      expect(pref_a.reload.working_patterns).to match_array(%w[full_time part_time])
+    end
+
+    it "fixes up flexible full_time" do
+      expect(pref_b.reload.working_patterns).to match_array(%w[part_time full_time])
+    end
+
+    it "fixes up term_time" do
+      expect(pref_c.reload.working_patterns).to match_array(%w[full_time])
+    end
+  end
 end