Refactor "discard/trash" tasks logic with same approach

Author: scruti

app/models/published_vacancy.rb

@@ -86,6 +86,13 @@ def find_publisher_by_contact_email
              .find_by(email: contact_email)
   end
 
+  def self.discard_out_of_scope
+    kept.joins(:organisations)
+        .where(organisations: { detailed_school_type: Organisation::OUT_OF_SCOPE_DETAILED_SCHOOL_TYPES })
+        .distinct
+        .find_each(&:trash!)
+  end
+
   private
 
   def remove_google_index

app/models/subscription.rb

@@ -92,6 +92,10 @@ def set_location_data!
     save!
   end
 
+  def self.discard_invalid
+    find_each.reject(&:valid?).each(&:discard!)
+  end
+
   private
 
   # A subscription with location area has a polygon area seat buffered by radius, no geopoint.

lib/tasks/data.rake

@@ -78,6 +78,20 @@ namespace :backfills do
   end
 end
 
+namespace :subscriptions do
+  desc "Discard subscriptions that fail validation (probably due to invalid email address)"
+  task discard_invalid: :environment do
+    Subscription.discard_invalid
+  end
+end
+
+namespace :vacancies do
+  desc "Trash published vacancies from out-of-scope schools"
+  task discard_out_of_scope: :environment do
+    PublishedVacancy.discard_out_of_scope
+  end
+end
+
 namespace :publishers do
   desc "Reset 'New features' attributes so all publishers are shown 'New features' page"
   task reset_new_features_attributes: :environment do

lib/tasks/discard_invalid_subscriptions.rake

@@ -0,0 +1,26 @@
+require "rails_helper"
+
+RSpec.describe PublishedVacancy do
+  describe ".discard_out_of_scope" do
+    it "trashes vacancies from out-of-scope schools" do
+      in_scope_school = create(:school, detailed_school_type: "Academy sponsor led")
+      in_scope_vacancy = create(:vacancy, organisations: [in_scope_school])
+      out_of_scope_school = create(:school, detailed_school_type: "Other independent school")
+      further_education_school = create(:school, detailed_school_type: "Further education")
+      higher_education_school = create(:school, detailed_school_type: "Higher education institutions")
+
+      out_of_scope_vacancy = create(:vacancy, organisations: [out_of_scope_school])
+      further_ed_vacancy = create(:vacancy, organisations: [further_education_school])
+      higher_ed_vacancy = create(:vacancy, organisations: [higher_education_school])
+
+      expect {
+        described_class.discard_out_of_scope
+      }.to change { described_class.kept.count }.by(-3)
+
+      expect(out_of_scope_vacancy.reload).to be_discarded
+      expect(further_ed_vacancy.reload).to be_discarded
+      expect(higher_ed_vacancy.reload).to be_discarded
+      expect(in_scope_vacancy.reload).not_to be_discarded
+    end
+  end
+end

lib/tasks/discard_out_of_scope_vacancies.rake

@@ -361,4 +361,17 @@
       end
     end
   end
+
+  describe ".discard_invalid" do
+    before do
+      create(:subscription)
+      build(:subscription, email: "invalid").save!(validate: false)
+    end
+
+    it "marks the invalid subscription as discarded" do
+      expect {
+        described_class.discard_invalid
+      }.to change { Subscription.kept.count }.by(-1)
+    end
+  end
 end