Use correct translation pattern

Author: KyleMacPherson

app/views/publishers/vacancies/job_applications/online_checks/edit.html.slim

@@ -14,11 +14,11 @@
     = form_with model: @job_application, url: organisation_job_job_application_online_checks_path(@vacancy.id, @job_application.id), method: :patch do |f|
       = f.govuk_error_summary
 
-      = f.govuk_radio_buttons_fieldset :online_checks, legend: { text: t(".question"), size: "m" } do
-        = f.govuk_radio_button :online_checks, :yes, label: { text: t(".yes") }
-        = f.govuk_radio_button :online_checks, :no, label: { text: t(".no") }
+      = f.govuk_radio_buttons_fieldset :online_checks, legend: { size: "m" } do
+        = f.govuk_radio_button :online_checks, :yes
+        = f.govuk_radio_button :online_checks, :no
         = f.govuk_radio_divider
-        = f.govuk_radio_button :online_checks, :not_doing, label: { text: t(".not_doing") }
+        = f.govuk_radio_button :online_checks, :not_doing
 
       = f.govuk_submit t(".save_and_update")
 

config/locales/publishers/vacancies/job_applications.en.yml

@@ -1,4 +1,14 @@
 en:
+  helpers:
+    label:
+      job_application:
+        online_checks_options:
+          "yes": "Yes"
+          "no": "No"
+          not_doing: Not doing online checks
+    legend:
+      job_application:
+        online_checks: Have online checks been completed?
   publishers:
     vacancies:
       job_applications:
@@ -123,10 +133,6 @@ en:
             online_checks: Online checks
             intro_paragraph_1: Schools and colleges should consider carrying out an online search as part of their due diligence on the shortlisted candidates. This may help identify any incidents or issues that have happened, and are publicly available online, which you might want to explore with the applicant at interview.
             intro_paragraph_2: Your online search approach should be agreed in advance and applied consistently to all shortlisted candidates.
-            question: Have online checks been completed?
-            "yes": "Yes"
-            "no": "No"
-            not_doing: Not doing online checks
             save_and_update: Save and update
           update:
             success: Online checks updated