Open
Conversation
567b8b0 to
d83dada
Compare
d83dada to
18d07aa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trello card URL
https://trello.com/c/y33lZvtU/2461-update-school-profiles-school-description-page-to-have-the-rich-text-editor
Changes in this PR:
This PR updates the School/Organisation profile description to use the rich text editor (Trix), creating a consistent experience with the Personal Statement editor. This allows schools to add formatting (bullets, bolding, etc.) to their profiles.
Technical Implementation:
Views: Replaced the standard
govuk_text_areain the profile edit form withrich_text_area(including a<noscript>fallback).Model: Updated
Organisation.rbto usehas_rich_text :description.Migration & Safety: - Added a migration
MigrateSchoolDescriptionToRichTextto safely copy existing description text from theorganisationstable to theaction_text_rich_textstable so no data is lost.self.ignored_columns += %w[description]on theOrganisationmodel. This allows us to switch to the ActionText association immediately without needing to drop or rename the column in a way that would cause downtime or lock the database (avoidingonline_migrationsconflicts).Is there anything specific you want feedback on?
find_eachloop) is performant and safe for production.Checklists:
Data & Schema Changes
If this PR modifies data structures or validations, check the following:
If any of the above options has changed then the author must check/resolve all of the following...
Integration Impact
Does this change affect any of these integrations?
User Experience & Data Integrity
Could this change impact: