Skip to content

convert job_title to govuk_text_field #8496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
starswan wants to merge 4 commits into
base: main
Choose a base branch
from
+4 −1
Open

convert job_title to govuk_text_field #8496

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3adbe41
convert job_title to govuk_text_field
starswan Feb 4, 2026
2e008e4
revert job title, limit row count
starswan Feb 6, 2026
140e04f
linter
starswan Feb 6, 2026
0eac20d
coverage weirdness
starswan Feb 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .simplecov
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,6 @@ if ENV.fetch("COVERAGE", 0).to_i.positive?
# possibly the tests are stable now?
# SD 16/01/26 branch coverage still appears to be ~ .1% unstable
# 97.48% (12352 / 12673) -> 322 86.37% (2776 / 3214) -> 185 + 225 = 410
minimum_coverage line: 97.45, branch: 86.36
minimum_coverage line: 97.44, branch: 87.18
end
end
3 changes: 3 additions & 0 deletions app/views/publishers/vacancies/build/job_title.html.slim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,14 @@ end
= form_for form, url: wizard_path(current_step), method: :patch do |f|
= f.govuk_error_summary

/ This is a text_area pretending to be a text_input so we get the running total of characters remaining
/ so we limit the number of rows to 1
= f.govuk_text_area :job_title,
label: { text: vacancy_form_page_heading(vacancy, step_process, back_path: back_path), tag: "h1", size: "l" },
hint: { text: vacancy_job_title_form_hint_text(vacancy) },
class: "govuk-input",
max_chars: 75,
rows: 1,
required: true

= render "publishers/vacancies/vacancy_form_partials/submit", f: f
Loading