Merged
Conversation
Contributor
Author
|
Mhm. Thinking about this again. The 0.11. file must be added AFTER the release was made. But that will cause the tests to fail with the release. What do you think about keeping it simple and just running UPDATE terracotta SET version='0.10.0'if there are no migrations? |
Collaborator
|
I like what you have implemented. I can see how it's not perfect but failing that test on release versions shouldn't be too consequential. There is a lot more we could do but given that we release only a few times per year this is probably low ROI to fix. Merging for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I just ran my deploy, but we forgot to add the migrations for the (major) version...
The startup fails due to a version mismatch, but we cannot perform a migration because it is missing. Even though it's a noop migration we need it.
I changed the tests to NOT skip when the next, upcoming migration is missing. This should prevent that from happening again.
Part of the release should be adding a new (upcoming) migration. So releasing 0.11 should instantly add the 0.12 migration - otherwise the tests will fail.
This is not perfect, but since we need to upgrade the db version, it's not a true noop migration, so just skipping is not a great idea...