Skip to content

add missing migrations#372

Merged
dionhaefner merged 2 commits intoDHI:mainfrom
jkittner:missing-migrations
Jan 14, 2026
Merged

add missing migrations#372
dionhaefner merged 2 commits intoDHI:mainfrom
jkittner:missing-migrations

Conversation

@jkittner
Copy link
Contributor

I just ran my deploy, but we forgot to add the migrations for the (major) version...

The startup fails due to a version mismatch, but we cannot perform a migration because it is missing. Even though it's a noop migration we need it.

I changed the tests to NOT skip when the next, upcoming migration is missing. This should prevent that from happening again.

Part of the release should be adding a new (upcoming) migration. So releasing 0.11 should instantly add the 0.12 migration - otherwise the tests will fail.

This is not perfect, but since we need to upgrade the db version, it's not a true noop migration, so just skipping is not a great idea...

@jkittner
Copy link
Contributor Author

Mhm. Thinking about this again. The 0.11. file must be added AFTER the release was made. But that will cause the tests to fail with the release.

What do you think about keeping it simple and just running

UPDATE terracotta SET version='0.10.0'

if there are no migrations?

@dionhaefner
Copy link
Collaborator

I like what you have implemented. I can see how it's not perfect but failing that test on release versions shouldn't be too consequential.

There is a lot more we could do but given that we release only a few times per year this is probably low ROI to fix. Merging for now.

@dionhaefner dionhaefner merged commit 6db38d5 into DHI:main Jan 14, 2026
7 checks passed
@jkittner jkittner deleted the missing-migrations branch January 26, 2026 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants