removed scopes for log4j dependencies, both are included as 'compile'…#28
Open
jaksat0202 wants to merge 1 commit intoDICE-UNC:masterfrom
Open
removed scopes for log4j dependencies, both are included as 'compile'…#28jaksat0202 wants to merge 1 commit intoDICE-UNC:masterfrom
jaksat0202 wants to merge 1 commit intoDICE-UNC:masterfrom
Conversation
Collaborator
|
@JustinKyleJames / @korydraughn - Any thoughts on this? |
Contributor
|
This change requires testing downstream projects - e.g. metalnx, nfsrods, etc. |
Author
|
As I commented in PR #139 for iDrop this change should not be necessary if you accept the removal of dynamic logging configuration in iDrop. |
Contributor
|
Ah. Somehow I missed the comment you highlighted. We'll review/build/run your PR and if everything checks out, we'll approve it. |
Contributor
|
@jaksat0202 Your PR at irods-contrib/idrop#139 has been reviewed and is ready for squashing. See latest comments in that PR for next steps. The change to move away from the dynamic logging configuration is accepted. We'll close this PR once irods-contrib/idrop#139 is merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are problems compiling dynamic logging configuration in iDrop when scope for log4j-core is 'runtime'.
The default scope in Maven is 'compile' anyway so it doesn't need to be specified in pom.xml at all.