Skip to content

fix: dirac-apptainer-exec: do not use minimal install #8269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: integration
Choose a base branch
from
Open

fix: dirac-apptainer-exec: do not use minimal install #8269

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/DIRAC/Core/scripts/dirac_apptainer_exec.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,6 @@ def main():

# Now let's construct the apptainer command
cmd = ["apptainer", "exec"]
cmd.extend(["--contain"]) # use minimal /dev and empty other directories (e.g. /tmp and $HOME)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure this is breaking half of the security gaurentee we get from SingularityCE. If this isn't the case we at the very least need a clear explanation in the description of why it isn't.

I also don't think it even fixes the error in the description.

cmd.extend(["--ipc"]) # run container in a new IPC namespace
cmd.extend(["--pid"]) # run container in a new PID namespace
cmd.extend(["--bind", f"{os.getcwd()}"]) # bind current directory for dirac_container.sh
Expand Down
Loading