Skip to content

fix: Convert MemoryLimitMB to int before comparison in SingularityComputingElement #8424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chrisburr wants to merge 2 commits into
base: integration
Choose a base branch
from
+3 −3
Open

fix: Convert MemoryLimitMB to int before comparison in SingularityComputingElement #8424

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f7a1353
fix: Convert MemoryLimitMB to int before comparison in SingularityCom…
chrisburr Jan 13, 2026
7814c0a
fix: RAM should always be an int
fstagni Jan 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/DIRAC/Resources/Computing/SingularityComputingElement.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -421,7 +421,7 @@ def submitJob(self, executableFile, proxy=None, **kwargs):
# if there's a max RAM available to the job, use that
if self.maxRAM:
self.ceParameters["MemoryLimitMB"] = min(
self.maxRAM, self.ceParameters.get("MemoryLimitMB", 1024 * 1024)
self.maxRAM, int(self.ceParameters.get("MemoryLimitMB", 1024 * 1024))
) # 1024 * 1024 is an arbitrary large number
result = CG2Manager().systemCall(
0, cmd, callbackFunction=self.sendOutput, env=self.__getEnv(), ceParameters=self.ceParameters
Expand Down
4 changes: 2 additions & 2 deletions src/DIRAC/WorkloadManagementSystem/Utilities/JobParameters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,7 @@ def getAvailableRAM(siteName=None, gridCE=None, queue=None):
gLogger.info("Looking in", csPath)
availableRAM = gConfig.getValue(csPath, None)
if availableRAM:
return availableRAM
return int(availableRAM)

# 3) checks if 'WholeNode' is one of the used tags
# Tags of the CE
Expand Down Expand Up @@ -277,6 +277,6 @@ def getRAMForJob(jobID):
# from /Resources/Computing/JobLimits/jobID/MaxRAM (set by PoolComputingElement)
ram = gConfig.getValue(f"Resources/Computing/JobLimits/{jobID}/MaxRAM")
if ram:
return ram
return int(ram)

return getAvailableRAM()
Loading