Conversation
2854065 to
1458d25
Compare
5adef1f to
dd2dd95
Compare
ryuwd
left a comment
There was a problem hiding this comment.
Looks good with some small suggestions!
packages/diracx-web-components/src/components/JobMonitor/JobSunburst.tsx
Outdated
Show resolved
Hide resolved
packages/diracx-web-components/src/components/JobMonitor/JobSunburst.tsx
Outdated
Show resolved
Hide resolved
packages/diracx-web-components/src/components/JobMonitor/JobSunburst.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Pull Request Overview
This PR adds pie chart visualization capabilities to the JobMonitor component using a Sunburst chart. The implementation includes a new chart component that allows users to visualize job data hierarchically and adds a toggle to switch between table and chart views.
- Adds a new Sunburst chart component for hierarchical data visualization
- Implements a column selector component for configuring chart grouping
- Adds a toggle button to switch between table and chart views in JobMonitor
Reviewed Changes
Copilot reviewed 42 out of 44 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/diracx-web-components/src/components/JobMonitor/JobMonitor.tsx | Added chart type selector and JobSunburst component integration |
| packages/diracx-web-components/src/components/JobMonitor/JobSunburst.tsx | New component for sunburst visualization of job data |
| packages/diracx-web-components/src/components/shared/Sunburst/Sunburst.tsx | Core D3-based sunburst chart implementation |
| packages/diracx-web-components/src/components/shared/ColumnSelector.tsx | New component for selecting and ordering chart columns |
| packages/diracx-web-components/src/components/shared/ChartDisplayLayout.tsx | Layout component for chart and column selector |
Comments suppressed due to low confidence (1)
packages/diracx-web-components/src/components/shared/Sunburst/Sunburst.tsx:208
- The magic number 0.05 (5% threshold) should be extracted to a constant or made configurable for better maintainability.
mouseOut.call(this, event, p);
packages/diracx-web-components/src/components/JobMonitor/JobMonitor.tsx
Outdated
Show resolved
Hide resolved
packages/diracx-web-components/src/components/JobMonitor/JobSunburst.tsx
Show resolved
Hide resolved
packages/diracx-web-components/src/components/shared/Sunburst/Sunburst.tsx
Show resolved
Hide resolved
packages/diracx-web-components/src/components/shared/SearchBar/SearchBar.tsx
Show resolved
Hide resolved
packages/diracx-web-components/src/components/JobMonitor/jobDataService.ts
Outdated
Show resolved
Hide resolved
packages/diracx-web-components/src/components/JobMonitor/jobDataService.ts
Outdated
Show resolved
Hide resolved
dd2dd95 to
e804c1a
Compare
packages/diracx-web-components/src/components/shared/ChartDisplayLayout.tsx
Show resolved
Hide resolved
packages/diracx-web-components/src/components/JobMonitor/JobMonitor.tsx
Outdated
Show resolved
Hide resolved
packages/diracx-web-components/src/components/JobMonitor/JobMonitor.tsx
Outdated
Show resolved
Hide resolved
packages/diracx-web-components/src/components/JobMonitor/JobSearchBar.tsx
Show resolved
Hide resolved
|
|
||
| if (filters.length !== 0 && tokenEquations.length === 0) load(); | ||
| }, [filters, createSuggestions]); | ||
| }, []); |
There was a problem hiding this comment.
Why did you choose not to include filters, tokenEquations, convertFilterToTokenEquation and setTokenEquations here?
There was a problem hiding this comment.
I originally wanted to initialize the tokens only once at startup, but I realized it makes sense to update them whenever the filters change (external changes). I fixed it here: #388.
I didn't do it in this PR because I couldn't just add the dependencies — I did that in a separate one.
37ee3de to
d4f0131
Compare
d4f0131 to
cf0fec0
Compare
I added a button to the
JobMonitorto visualize jobs using theSunburstchart. This will be reused in theBookkeeping Storage report.I also exposed the
columnSelectorcomponent, which will be reused in theBookkeeping Storage report.I updated the
Sunburstto reflect recent changes suggested in gitlab/lhcbdiracx-web and added the ability to refresh jobs.