Skip to content

Requests → httpx#374

Merged
chaen merged 10 commits intoDIRACGrid:mainfrom
maxnoe:remove_requests
Jan 17, 2025
Merged

Requests → httpx#374
chaen merged 10 commits intoDIRACGrid:mainfrom
maxnoe:remove_requests

Conversation

@maxnoe
Copy link
Contributor

@maxnoe maxnoe commented Jan 15, 2025

Notes for reviewers:

  • The get_openid_config seems to be not covered by tests, see 55522d5
  • requests was imported in the patch file for the autogenerated client code, but marked as not used. See 7de3db1
  • The async client uses the sync get_openid_config, should probably be using its own async version

Fixes #338

@chaen chaen closed this Jan 16, 2025
@chaen chaen reopened this Jan 16, 2025
@maxnoe maxnoe force-pushed the remove_requests branch 3 times, most recently from e9cc268 to 0b85ed3 Compare January 16, 2025 11:03
@chaen chaen enabled auto-merge January 17, 2025 15:54
@chaen chaen merged commit 8d410ad into DIRACGrid:main Jan 17, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use httpx instead of requests

2 participants