Merged
Conversation
2e412d7 to
6554102
Compare
6554102 to
52fcf90
Compare
chrisburr
approved these changes
Feb 20, 2025
52fcf90 to
b26b1b5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #341
Note:
I disable
inherit_cacheindate_truncbecause I had weird results when calling thesearchendpoint multiple times in a row.The
time_resolutiondoes not seem to be part of the cached keys and whatever is the firsttime_resolutionto be used becomes the "reference" in subsequent calls.Example:
Here
?seems to be replaced with the first cached value instead of the one we want to use.I haven't found an easy way to include the
time_resolutionparameter in the cache keys, but my knowledge ofsqlalchemyis very limited, and I might have overlooked something.If you want to easily reproduce the issue, you can just switch
inherit_cachetoTrueand execute the tests.