Add PubButtonGroup and PubBadge components with documentation updates#6
Add PubButtonGroup and PubBadge components with documentation updates#6shivishbrahma wants to merge 16 commits intomainfrom
Conversation
- Add WithIcon.vue demo component showing buttons with prepend/append icons - Create Rounded.vue demo for PubButtonGroup - Update button theme documentation to reflect current theme options - Fix button label in ButtonGroup demo (Purple -> Blue) - Add new examples to component documentation pages
style(PubBadge): add class prop for additional styling options
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly expands the UI component library by introducing two new components, Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces two new components, PubBadge and PubButtonGroup, complete with documentation and demos. It also features a significant theme overhaul, including a script for generating color scales, and enhances the component creation script. While the additions are substantial and well-structured, I've identified several areas for improvement. There are critical issues in the theme generation script and a utility function that could cause incorrect styling. Additionally, I've noted some incorrect demo implementations, an undocumented breaking change, and minor inconsistencies. My review includes specific suggestions to address these points and improve the overall quality and correctness of the new features.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
… refactor utility functions
No description provided.