Skip to content

Conversation

@Davknapp
Copy link
Collaborator

@Davknapp Davknapp commented Dec 9, 2025

Closes #2032

With 4.0.0 we want to switch to a rolling release. This wf automizes it.
See https://github.com/DLR-AMR/t8code/releases/tag/v4.0.0-2025.12.09 as an example.
Delete that tag befor merging into main.

All these boxes must be checked by the AUTHOR before requesting review:

  • The PR is small enough to be reviewed easily. If not, consider splitting up the changes in multiple PRs.
  • The title starts with one of the following prefixes: Documentation:, Bugfix:, Feature:, Improvement: or Other:.
  • If the PR is related to an issue, make sure to link it.
  • The author made sure that, as a reviewer, he/she would check all boxes below.

All these boxes must be checked by the REVIEWERS before merging the pull request:

As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.

General

  • The reviewer executed the new code features at least once and checked the results manually.
  • The code follows the t8code coding guidelines.
  • New source/header files are properly added to the CMake files.
  • The code is well documented. In particular, all function declarations, structs/classes and their members have a proper doxygen documentation.
  • All new algorithms and data structures are sufficiently optimal in terms of memory and runtime (If this should be merged, but there is still potential for optimization, create a new issue).

Tests

  • The code is covered in an existing or new test case using Google Test.
  • The code coverage of the project (reported in the CI) should not decrease. If coverage is decreased, make sure that this is reasonable and acceptable.
  • Valgrind doesn't find any bugs in the new code. This script can be used to check for errors; see also this wiki article.

If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):

  • Should this use case be added to the github action?
  • If not, does the specific use case compile and all tests pass (check manually).

Scripts and Wiki

  • If a new directory with source files is added, it must be covered by the script/find_all_source_files.scp to check the indentation of these files.
  • If this PR introduces a new feature, it must be covered in an example or tutorial and a Wiki article.

License

  • The author added a BSD statement to doc/ (or already has one).

@Davknapp Davknapp marked this pull request as ready for review December 9, 2025 13:51
@codecov
Copy link

codecov bot commented Dec 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.75%. Comparing base (6fd67dc) to head (527d311).
⚠️ Report is 35 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2031   +/-   ##
=======================================
  Coverage   76.75%   76.75%           
=======================================
  Files         109      109           
  Lines       18750    18750           
=======================================
  Hits        14392    14392           
  Misses       4358     4358           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@lenaploetzke lenaploetzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and seems to work :)

@lenaploetzke
Copy link
Collaborator

Ah and the tarball is missing as you pointed out.

@Davknapp Davknapp assigned lenaploetzke and unassigned Davknapp Dec 17, 2025
@Davknapp
Copy link
Collaborator Author

Ah and the tarball is missing as you pointed out.

I don't think that this is actually a problem. Github automatically adds a tarball to the tag. We should try to build t8code from that. Than we don't have to create it manually.

@Davknapp
Copy link
Collaborator Author

Ah and the tarball is missing as you pointed out.

I don't think that this is actually a problem. Github automatically adds a tarball to the tag. We should try to build t8code from that. Than we don't have to create it manually.

We can not do that, because the version is not properly set in the tarball.

Copy link
Collaborator

@lenaploetzke lenaploetzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your changes!

@Davknapp Davknapp assigned lenaploetzke and unassigned Davknapp Dec 17, 2025
@lenaploetzke lenaploetzke added this pull request to the merge queue Dec 17, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 17, 2025
@Davknapp Davknapp added this pull request to the merge queue Dec 18, 2025
Merged via the queue into main with commit dadba54 Dec 18, 2025
25 checks passed
@Davknapp Davknapp deleted the rolling-release branch December 18, 2025 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improvement: Automate the creation of a version tag on a monthly basis

3 participants