-
Notifications
You must be signed in to change notification settings - Fork 63
Improvement: Introduce github workflow using Clang and OpenMPI #2055
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2055 +/- ##
=======================================
Coverage 77.05% 77.05%
=======================================
Files 112 112
Lines 18959 18959
=======================================
Hits 14608 14608
Misses 4351 4351 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Since this is only meant as a test for clang warnings and not for bugs etc., I would suggest to build t8code with the settings which compile the most of our codebase. Meaning that we should also enable VTK, OCC and NetCDF linkage and enable our Fortran API :) |
Closes #2056
Resulted from the discussion in #1528 - which can be closed afterwards.
Describe your changes here:
This PR introduces a new github workflow that tests t8code with Clang and OpenMPI. To not bloat the runtime, it only uses Debug mode, MPI ON, and no external libraries like VTK - which however, may easily be changed later if we decide we need that.
Note that the workflow uses an own docker image, that is created based on the new Dockerfile introduced in DLR-AMR/t8code-docker-images#3 (this PR is not merged yet, but the docker image has already been published by its CI workflow).
Don't worry, I will squash the commits before merging 😆
All these boxes must be checked by the AUTHOR before requesting review:
Documentation:,Bugfix:,Feature:,Improvement:orOther:.All these boxes must be checked by the REVIEWERS before merging the pull request:
As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.
General
Tests
If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):
Scripts and Wiki
script/find_all_source_files.scpto check the indentation of these files.License
doc/(or already has one).