Improvement: Remove support of gmsh mesh format 2 #2072
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2071
Describe your changes here:
This is still a draft. There are two open issues I would like to discuss briefly in the next dev meeting (unless someone can answer them already, for example, @sandro-elsweijer?) :
example/IO/cmesh/gmsh/t8_load_and_refine_square_w_hole.cxxdoes not work onorigin/main(unless I did something wrong). I updated the associated mesh file to version 4.1, but I cannot properly test it - except for confirming that the error message is still the same 😆 I can look into it but maybe it is a known issue?su2_mesh_to_gmsh.pywrites a gmsh file of mesh format version 2.2 as an output. Before I or someone looks into how to update it to version 4.1: Do we still need this script or is it some outdated functionality?All these boxes must be checked by the AUTHOR before requesting review:
Documentation:,Bugfix:,Feature:,Improvement:orOther:.All these boxes must be checked by the REVIEWERS before merging the pull request:
As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.
General
Tests
If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):
Scripts and Wiki
script/find_all_source_files.scpto check the indentation of these files.License
doc/(or already has one).