Skip to content

fix: failure in global.wast spec test#179

Merged
wucke13 merged 1 commit intomainfrom
dev/wucke13-make-global-spec-compliant
May 28, 2025
Merged

fix: failure in global.wast spec test#179
wucke13 merged 1 commit intomainfrom
dev/wucke13-make-global-spec-compliant

Conversation

@wucke13
Copy link
Copy Markdown
Collaborator

@wucke13 wucke13 commented May 28, 2025

Pull Request Overview

Make global.wast spec test pass.

TODO or Help Wanted

I'm not so sure about what I'm doing there in the test runner, keen look would be welcome.

Checks

  • Using Nix
    • Ran nix fmt
    • Ran nix flake check '.?submodules=1'
  • Using Rust tooling
    • Ran cargo fmt
    • Ran cargo test
    • Ran cargo check
    • Ran cargo build
    • Ran cargo doc

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 28, 2025 •
edited
Loading

🗒️ WebAssembly Testsuite Report

Changes

File Diff Now passing Now passing%
✅ br_table.wast
3 passing- L. 1188: Previous error: handling of wast ret type RefExtern(Some(1)) not yet implemented
- L. 1189: Previous error: handling of wast ret type RefExtern(Some(1)) not yet implemented
- L. 1190: Previous error: handling of wast ret type RefExtern(Some(1)) not yet implemented
 173/173 (+3) 100.0% (+1.7%)
✅ global.wast
1 passing- L. 229: Previous error: handling of wast ret type RefExtern(Some(10)) not yet implemented
 105/105 (+1) 100.0% (+1.0%)
✅ select.wast
3 passing- L. 216: Previous error: handling of wast ret type RefExtern(Some(1)) not yet implemented
- L. 222: Previous error: handling of wast ret type RefExtern(Some(2)) not yet implemented
- L. 223: Previous error: handling of wast ret type RefExtern(Some(1)) not yet implemented
 146/146 (+3) 100.0% (+2.1%)
✅ table_fill.wast
13 passing- L. 25: Previous error: handling of wast ret type RefExtern(Some(1)) not yet implemented
- L. 26: Previous error: handling of wast ret type RefExtern(Some(1)) not yet implemented
- L. 27: Previous error: handling of wast ret type RefExtern(Some(1)) not yet implemented
- L. 31: Previous error: handling of wast ret type RefExtern(Some(1)) not yet implemented
- L. 32: Previous error: handling of wast ret type RefExtern(Some(2)) not yet implemented
- L. 33: Previous error: handling of wast ret type RefExtern(Some(2)) not yet implemented
- L. 37: Previous error: handling of wast ret type RefExtern(Some(1)) not yet implemented
- L. 38: Previous error: handling of wast ret type RefExtern(Some(2)) not yet implemented
- L. 39: Previous error: handling of wast ret type RefExtern(Some(2)) not yet implemented
- L. 43: Previous error: handling of wast ret type RefExtern(Some(4)) not yet implemented
- L. 44: Previous error: handling of wast ret type RefExtern(Some(4)) not yet implemented
- L. 47: Previous error: handling of wast ret type RefExtern(Some(4)) not yet implemented
- L. 58: Previous error: handling of wast ret type RefExtern(Some(4)) not yet implemented
 44/44 (+13) 100.0% (+29.5%)
✅ table_get.wast
1 passing- L. 27: Previous error: handling of wast ret type RefExtern(Some(1)) not yet implemented
 14/14 (+1) 100.0% (+7.1%)
✅ table_set.wast
1 passing- L. 31: Previous error: handling of wast ret type RefExtern(Some(1)) not yet implemented
 25/25 (+1) 100.0% (+4.0%)

Per-test details

Click here to open
File Passed Asserts Failed Asserts % Passed Notes
f64_bitwise.wast 363 / 363 0 / 363 100% -
store.wast 67 / 67 0 / 67 100% -
block.wast 222 / 222 0 / 222 100% -
token.wast 23 / 23 0 / 23 100% -
memory_size.wast 38 / 38 0 / 38 100% -
ref_is_null.wast 13 / 13 0 / 13 100% -
call.wast 88 / 90 2 / 90 97.77778% -
table.wast 10 / 10 0 / 10 100% -
const.wast 376 / 376 0 / 376 100% -
imports.wast 54 / 125 71 / 125 43.2% -
fac.wast 6 / 7 1 / 7 85.71429% -
nop.wast 87 / 87 0 / 87 100% -
inline-module.wast 0 / 0 0 / 0 - -
align.wast 137 / 137 0 / 137 100% -
comments.wast 3 / 3 0 / 3 100% -
f32_cmp.wast 2406 / 2406 0 / 2406 100% -
ref_null.wast 2 / 2 0 / 2 100% -
if.wast 240 / 240 0 / 240 100% -
i32.wast 459 / 459 0 / 459 100% -
memory_redundancy.wast 4 / 4 0 / 4 100% -
float_literals.wast 177 / 177 0 / 177 100% -
table_fill.wast 44 / 44 0 / 44 100% -
memory_grow.wast - - - Context: Module directive (WAT) failed in validation or instantiation.
Line: 318
select.wast 146 / 146 0 / 146 100% -
local_set.wast 52 / 52 0 / 52 100% -
table_size.wast 38 / 38 0 / 38 100% -
br.wast 96 / 96 0 / 96 100% -
br_if.wast 117 / 117 0 / 117 100% -
memory_init.wast 207 / 207 0 / 207 100% -
address.wast 256 / 256 0 / 256 100% -
f64.wast 2513 / 2513 0 / 2513 100% -
func.wast 168 / 168 0 / 168 100% -
elem.wast - - - Context: Module directive (WAT) failed in validation or instantiation.
Line: 673
memory_trap.wast 180 / 180 0 / 180 100% -
custom.wast 6 / 8 2 / 8 75% -
table-sub.wast 2 / 2 0 / 2 100% -
utf8-import-module.wast 176 / 176 0 / 176 100% -
load.wast 96 / 96 0 / 96 100% -
f32.wast 2513 / 2513 0 / 2513 100% -
unreached-invalid.wast 118 / 118 0 / 118 100% -
conversions.wast 618 / 618 0 / 618 100% -
start.wast 10 / 11 1 / 11 90.90909% -
unwind.wast 49 / 49 0 / 49 100% -
memory.wast 77 / 77 0 / 77 100% -
type.wast 2 / 2 0 / 2 100% -
loop.wast 119 / 119 0 / 119 100% -
memory_fill.wast 84 / 84 0 / 84 100% -
int_exprs.wast 89 / 89 0 / 89 100% -
binary-leb128.wast - - - Context: Module directive (WAT) failed in validation or instantiation.
Line: 969
ref_func.wast - - - Context: Module directive (WAT) failed in validation or instantiation.
Line: 6
local_tee.wast 96 / 96 0 / 96 100% -
forward.wast 4 / 4 0 / 4 100% -
i64.wast 415 / 415 0 / 415 100% -
utf8-import-field.wast 176 / 176 0 / 176 100% -
table_copy.wast 1649 / 1649 0 / 1649 100% -
f64_cmp.wast 2406 / 2406 0 / 2406 100% -
utf8-custom-section-id.wast 176 / 176 0 / 176 100% -
table_grow.wast - - - Context: Module directive (WAT) failed in validation or instantiation.
Line: 117
binary.wast 115 / 115 0 / 115 100% -
func_ptrs.wast 32 / 32 0 / 32 100% -
left-to-right.wast 0 / 95 95 / 95 0% -
data.wast 21 / 36 15 / 36 58.333332% -
traps.wast 32 / 32 0 / 32 100% -
float_exprs.wast 819 / 819 0 / 819 100% -
float_misc.wast 470 / 470 0 / 470 100% -
skip-stack-guard-page.wast 0 / 10 10 / 10 0% -
exports.wast 37 / 40 3 / 40 92.5% -
obsolete-keywords.wast 11 / 11 0 / 11 100% -
call_indirect.wast 165 / 167 2 / 167 98.8024% -
utf8-invalid-encoding.wast 176 / 176 0 / 176 100% -
labels.wast 28 / 28 0 / 28 100% -
br_table.wast 173 / 173 0 / 173 100% -
f32_bitwise.wast 363 / 363 0 / 363 100% -
int_literals.wast 50 / 50 0 / 50 100% -
return.wast 83 / 83 0 / 83 100% -
switch.wast 27 / 27 0 / 27 100% -
table_init.wast 729 / 729 0 / 729 100% -
unreachable.wast 63 / 63 0 / 63 100% -
table_set.wast 25 / 25 0 / 25 100% -
table_get.wast 14 / 14 0 / 14 100% -
bulk.wast 66 / 66 0 / 66 100% -
linking.wast 69 / 102 33 / 102 67.64706% -
memory_copy.wast 4402 / 4402 0 / 4402 100% -
names.wast - - - Context: failed to parse wast file
Line: -
stack.wast 5 / 5 0 / 5 100% -
float_memory.wast 60 / 60 0 / 60 100% -
local_get.wast 35 / 35 0 / 35 100% -
unreached-valid.wast - - - Context: Module directive (WAT) failed in validation or instantiation.
Line: 1
endianness.wast 68 / 68 0 / 68 100% -
global.wast 105 / 105 0 / 105 100% -

@codecov
Copy link
Copy Markdown

codecov bot commented May 28, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@wucke13 wucke13 force-pushed the dev/wucke13-make-global-spec-compliant branch 2 times, most recently from c3715be to c2b48ab Compare May 28, 2025 08:46
@wucke13 wucke13 enabled auto-merge May 28, 2025 08:46
@wucke13 wucke13 force-pushed the dev/wucke13-make-global-spec-compliant branch from c2b48ab to a6265c7 Compare May 28, 2025 09:31
@wucke13
fix: failure in global.wast spec test
0d733b4 
Signed-off-by: wucke13 <wucke13+github@gmail.com>
@wucke13 wucke13 force-pushed the dev/wucke13-make-global-spec-compliant branch from a6265c7 to 0d733b4 Compare May 28, 2025 09:32
@wucke13 wucke13 added this pull request to the merge queue May 28, 2025
Merged via the queue into main with commit 2808409 May 28, 2025
17 checks passed
@wucke13 wucke13 deleted the dev/wucke13-make-global-spec-compliant branch May 28, 2025 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cemonem cemonem cemonem approved these changes

@florianhartung florianhartung florianhartung approved these changes

Assignees

No one assigned

Labels

priority-medium tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wucke13 @cemonem @florianhartung