Skip to content

Modular Crates#330

Merged
florianhartung merged 12 commits intomainfrom
dev/modular-crates
Mar 18, 2026
Merged

Modular Crates#330
florianhartung merged 12 commits intomainfrom
dev/modular-crates

Conversation

@florianhartung
Copy link
Copy Markdown
Collaborator

Checks

  • Using Nix
    • Ran nix fmt
    • Ran nix flake check '.?submodules=1'
  • Using Rust tooling
    • Ran cargo fmt
    • Ran cargo test
    • Ran cargo check
    • Ran cargo build
    • Ran cargo doc

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 13, 2026

Codecov Report

❌ Patch coverage is 65.13158% with 212 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.11%. Comparing base (d45567a) to head (d298aca).
⚠️ Report is 12 commits behind head on main.

@@            Coverage Diff             @@
##             main     #330      +/-   ##
==========================================
- Coverage   77.55%   74.11%   -3.45%     
==========================================
  Files          41       43       +2     
  Lines       10435    10271     -164     
  Branches    10435    10271     -164     
==========================================
- Hits         8093     7612     -481     
- Misses       1180     1303     +123     
- Partials     1162     1356     +194     
Components Coverage Δ
interpreter 74.80% <72.91%> (-2.75%) ⬇️
checked 64.83% <61.58%> (∅)
linker 93.47% <100.00%> (∅)
interop 65.34% <100.00%> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@florianhartung florianhartung force-pushed the dev/modular-crates branch 10 times, most recently from 83ea2f7 to 39435b2 Compare March 17, 2026 15:39
Signed-off-by: Florian Hartung <florian.hartung@dlr.de>
Signed-off-by: Florian Hartung <florian.hartung@dlr.de>
@florianhartung florianhartung force-pushed the dev/modular-crates branch 10 times, most recently from 6abf778 to 39e5b96 Compare March 18, 2026 13:53
Signed-off-by: Florian Hartung <florian.hartung@dlr.de>
Signed-off-by: Florian Hartung <florian.hartung@dlr.de>
Previously, the RuntimeError included errors that were not used by the
core and instead only by the checked linker.

Signed-off-by: Florian Hartung <florian.hartung@dlr.de>
Signed-off-by: Florian Hartung <florian.hartung@dlr.de>
Signed-off-by: Florian Hartung <florian.hartung@dlr.de>
Signed-off-by: Florian Hartung <florian.hartung@dlr.de>
Signed-off-by: Florian Hartung <florian.hartung@dlr.de>
The id method was a potential error source for some types, such as
`Vec<StoredValue>`.

This is because the user has full access to the inner `StoredValue`s and
therefore it is not guaranteed anymore that all `StoredValue`s use the
same `StoreId`.

The solution is to remove the id method and instead require implementors
to implement the `try_unwrap_into_bare` method themselves.

Signed-off-by: Florian Hartung <florian.hartung@dlr.de>
Signed-off-by: Florian Hartung <florian.hartung@dlr.de>
Signed-off-by: Florian Hartung <florian.hartung@dlr.de>
@florianhartung florianhartung added this pull request to the merge queue Mar 18, 2026
Merged via the queue into main with commit 4b1b7ec Mar 18, 2026
15 of 17 checks passed
@florianhartung florianhartung deleted the dev/modular-crates branch March 18, 2026 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants