Skip to content

Rename the observations variable in the evaluation util to avoid shadowing #1288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 11, 2023
Merged

Rename the observations variable in the evaluation util to avoid shadowing #1288

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3d3f454
Rename the observations variable in the evaluation util to avoid shad…
npit Jan 18, 2023
f5cedca
Merge branch 'master' into fix-rename
araffin Apr 3, 2023
118a4d5
Update changelog
npit Apr 9, 2023
1eb3aa8
Merge branch 'master' into fix-rename
araffin Apr 11, 2023
308578f
Add test
araffin Apr 11, 2023
067c5df
Move assignment outside of the loop
araffin Apr 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion stable_baselines3/common/evaluation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ def evaluate_policy(
episode_starts = np.ones((env.num_envs,), dtype=bool)
while (episode_counts < episode_count_targets).any():
actions, states = model.predict(observations, state=states, episode_start=episode_starts, deterministic=deterministic)
observations, rewards, dones, infos = env.step(actions)
new_observations, rewards, dones, infos = env.step(actions)
current_rewards += rewards
current_lengths += 1
for i in range(n_envs):
Expand All @@ -100,6 +100,7 @@ def evaluate_policy(

if callback is not None:
callback(locals(), globals())
observations = new_observations

if dones[i]:
if is_monitor_wrapped:
Expand Down