Skip to content

Conversation

@NXXR
Copy link
Collaborator

@NXXR NXXR commented Apr 5, 2024

Description

This PR changes the Throbber used for loading suspense across all components of the app.
The PR also adds an upload popup for users to upload case data in the future.
Both the data upload, and sign in menu items in the app menu are disabled, as they are not fully functional yet.

Related Issues

Design Decisions

we decided on the Helix throbber (#22) by Griffin Jhonston as it fits with the health theme of ESID.
The size of the upload status icons was chosen to allow the throbbers to mesh with each other.

Checklist

I, the author of this PR checked the following requirements for good software quality:

  • The code is properly formatted (I ran the formatter)
  • The code is written with our software quality standards (I ran the linter)
  • The code is written using our code style
  • Extensive in source documentation has been added
  • Unit and/or integration tests have been added
  • All texts have been internationalized with at least the following languages:
    • English
    • German
  • I tried addressing all new accessibility problems displayed in the console and documented if they can't be fixed
  • I attached performance measurements to prevent performance degradation
  • I added the changes to the next release section of the changelog

I, the reviewer checked the following things:

  • I ran the software once and tried all new and related functionality to this PR
  • I looked at all new and changed lines of code and commented on possible problems
  • I read the added documentation and checked if it is understandable and clear
  • I checked the added tests for completeness
  • I checked the internationalized strings for spelling errors
  • I checked the performance metrics for problems or unexplained degradation
  • I checked that the changes are noted in the changelog

@NXXR NXXR self-assigned this Apr 5, 2024
@github-actions
Copy link

github-actions bot commented Apr 5, 2024

Test Results

133 tests  +133   133 ✅ +133   18s ⏱️ +18s
 40 suites + 40     0 💤 ±  0 
  1 files   +  1     0 ❌ ±  0 

Results for commit 3c1848a. ± Comparison against base commit f578619.

♻️ This comment has been updated with latest results.

@NXXR NXXR marked this pull request as ready for review November 24, 2025 14:42
@NXXR NXXR requested review from JonasGilg and Kanakanajm November 24, 2025 14:45
@NXXR NXXR requested a review from JonasGilg November 24, 2025 15:08
@NXXR NXXR dismissed JonasGilg’s stale review November 24, 2025 15:08

Suggestions added

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🏗 In Progress

Development

Successfully merging this pull request may close these issues.

3 participants