Skip to content

Conversation

@kunkoala
Copy link
Collaborator

@kunkoala kunkoala commented Oct 14, 2025

Description

Made a settings menu above data cards for the number display settings. Toggle between absolute and relative values (infections per 100k pop), and total number, 1d new infection, 7d new infection. Though the 1D and 7D data still uses the total number of infected.

Related Issues

#318

Design Decisions

Put a settings button that shows a settings popover for the number display when clicked.

Performance & Quality

Checklist

I, the author of this PR checked the following requirements for good software quality:

  • The code is properly formatted (I ran the formatter)
  • The code is written with our software quality standards (I ran the linter)
  • The code is written using our code style
  • Extensive in source documentation has been added
  • Unit and/or integration tests have been added
  • All texts have been internationalized with at least the following languages:
    • English
    • German
  • I tried addressing all new accessibility problems displayed in the console and documented if they can't be fixed
  • I attached performance measurements to prevent performance degradation
  • I added the changes to the next release section of the changelog

I, the reviewer checked the following things:

  • I ran the software once and tried all new and related functionality to this PR
  • I looked at all new and changed lines of code and commented on possible problems
  • I read the added documentation and checked if it is understandable and clear
  • I checked the added tests for completeness
  • I checked the internationalized strings for spelling errors
  • I checked the performance metrics for problems or unexplained degradation
  • I checked that the changes are noted in the changelog

@kunkoala kunkoala changed the title Feature/relative data settings data display settings Oct 14, 2025
@kunkoala kunkoala self-assigned this Oct 14, 2025
@github-actions
Copy link

github-actions bot commented Oct 14, 2025

Test Results

135 tests  +2   135 ✅ +2   37s ⏱️ +2s
 40 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit ae8a091. ± Comparison against base commit a0c4d2b.

♻️ This comment has been updated with latest results.

@kunkoala kunkoala marked this pull request as ready for review October 16, 2025 15:23
@kunkoala kunkoala requested review from JonasGilg and NXXR October 16, 2025 15:23
Copy link
Collaborator

@NXXR NXXR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good code wise.
Design wise I'd like to have the info chip next to the settings cog as a small info tag. otherwise it's quite removed and unintuitive.
I think it should also be part of the settings button, clicking the chip should also open the relevant setting popover.
image

⚠️ Also make sure this shows up somewhere in the export in #428 depending on which you merge first.

@kunkoala kunkoala requested a review from NXXR January 5, 2026 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants