-
Notifications
You must be signed in to change notification settings - Fork 3
data display settings #430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
…led through the linechart settings menu for now
…to handle negative numbers
…f time period by assuming new infection case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good code wise.
Design wise I'd like to have the info chip next to the settings cog as a small info tag. otherwise it's quite removed and unintuitive.
I think it should also be part of the settings button, clicking the chip should also open the relevant setting popover.

⚠️ Also make sure this shows up somewhere in the export in #428 depending on which you merge first.
Description
Made a settings menu above data cards for the number display settings. Toggle between absolute and relative values (infections per 100k pop), and total number, 1d new infection, 7d new infection. Though the 1D and 7D data still uses the total number of infected.
Related Issues
#318
Design Decisions
Put a settings button that shows a settings popover for the number display when clicked.
Performance & Quality
Checklist
I, the author of this PR checked the following requirements for good software quality:
I, the reviewer checked the following things: