Open
Conversation
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1148 +/- ##
==========================================
- Coverage 81.26% 81.23% -0.04%
==========================================
Files 141 141
Lines 5034 5030 -4
==========================================
- Hits 4091 4086 -5
- Misses 943 944 +1 ☔ View full report in Codecov by Sentry. |
Xyene
force-pushed
the
new-aborts
branch
2 times, most recently
from
041136c to
662a312
Compare
Riolku
added a commit
to Riolku/judge-server
that referenced
this pull request
Dec 27, 2023
This would have caught a failure on DMOJ#1148.
Riolku
added a commit
to Riolku/judge-server
that referenced
this pull request
Dec 27, 2023
This would have caught a failure on DMOJ#1148.
kiritofeng
pushed a commit
that referenced
this pull request
Dec 27, 2023
This would have caught a failure on #1148.
kiritofeng
force-pushed
the
new-aborts
branch
from
662a312 to
4c1b538
Compare
The way this works is: - Worker creates a tempdir, and sets `tempfile.tempdir` to this directory. - Worker sends back the tempdir. The parent process is responsible for cleaning it up when the worker exits. Abortions are then implemented as sending `SIGKILL` to the worker. As a side benefit of this implementation, we also get to drop the hacky `CompiledExecutor` cache deletion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The way this works is:
tempfile.tempdirto this directory.it up when the worker exits.
Abortions are then implemented as sending
SIGKILLto the worker.As a side benefit of this implementation, we also get to drop the hacky
CompiledExecutorcache deletion.