Make accessing Debugger registers more ergonomic#997
Open
Xyene wants to merge 2 commits intoDMOJ:masterfrom
Open
Make accessing Debugger registers more ergonomic#997Xyene wants to merge 2 commits intoDMOJ:masterfrom
Xyene wants to merge 2 commits intoDMOJ:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #997 +/- ##
==========================================
+ Coverage 81.12% 84.04% +2.92%
==========================================
Files 140 140
Lines 4753 4752 -1
==========================================
+ Hits 3856 3994 +138
+ Misses 897 758 -139
Continue to review full report at Codecov.
|
Xyene
force-pushed
the
debugger-arg-getitem
branch
4 times, most recently
from
424f96a to
415fe95
Compare
Xyene
force-pushed
the
debugger-arg-getitem
branch
from
415fe95 to
d6c7393
Compare
quantum5
reviewed
Feb 28, 2022
Member
quantum5
left a comment
quantum5
left a comment
There was a problem hiding this comment.
Otherwise the idea looks fine...
| self.base = base | ||
|
|
||
| def __getitem__(self, reg): | ||
| return getattr(self.debugger, '%s%d' % (self.base, reg)) |
Member
There was a problem hiding this comment.
Why are you doing this in _cptbox? Maybe you should move this into AdvancedDebugger instead.
Contributor
|
Agree on Quantum's comment, otherwise looks good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.