Skip to content

Conversation

@momo3404
Copy link
Collaborator

Fixes issue here: portagenetwork#1029

  • Changed html page for Error 403 to be more consistent with other error html pages.

@aaronskiba
Copy link
Contributor

Hi @momo3404, thank you for this. 🙏

@momo3404
Copy link
Collaborator Author

No worries! I'm not sure why Danger is failing. If it has something to do with the branch, I branched from DMPRoadmap's development branch in my fork and (my fork's dev branch had other changes I didn't want as part of this PR) and just made this one change in that branch (html-1029).

@aaronskiba
Copy link
Contributor

No worries! I'm not sure why Danger is failing. If it has something to do with the branch, I branched from DMPRoadmap's development branch in my fork and (my fork's dev branch had other changes I didn't want as part of this PR) and just made this one change in that branch (html-1029).

Yes, that is a Danger issue; nothing wrong on your end. https://github.com/portagenetwork is also forked off of DMPRoadmap and I always encounter the same when I submit a PR from there.

I just took a quick initial look; your PR is definitely an improvement, thank you again.

I had the issue marked on the forked repo (https://github.com/portagenetwork), and was going to suggest rebasing your branch and pointing the PR at theintegration branch of that repo. However, I think the same branding update might be needed here. I'll look into it, thank you.

@momo3404 momo3404 closed this Jun 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants