Skip to content

Properly Validate CSV Separator #3557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
momo3404 wants to merge 2 commits into from
Closed

Properly Validate CSV Separator #3557

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8d5628e
Added CSV separator validation
momo3404 Sep 8, 2025
e866eb6
Add changelog entry
momo3404 Sep 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
- Remove Auto-Generated TinyMCE Skins and Add `public/tinymce/skins/` to `.gitignore` [#3466](https://github.com/DMPRoadmap/roadmap/pull/3466)
- Re-implement email confirmation [#3507](https://github.com/DMPRoadmap/roadmap/pull/3507)
- Update `spec/support/faker.rb` to use `I18n.default_locale` [#3507](https://github.com/DMPRoadmap/roadmap/pull/3507)
- Properly validate CSV Separator [#3557](https://github.com/DMPRoadmap/roadmap/pull/3557)

## v5.0.0

Expand Down
9 changes: 7 additions & 2 deletions app/controllers/usage_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,9 +151,14 @@ def parse_filtered
params[:filtered].present? && params[:filtered] == 'true'
end

# set the csv separator or default to comma
# This sets the csv separator
# Ensures separator is either a comma or a safe separator
def sep_param
params['sep'] || ','
safe_csv_separators = Rails.configuration.x.application.csv_separators
sep = params['sep'].to_s
return sep if safe_csv_separators.include?(sep)

','
end

def min_max_dates(args:)
Expand Down