Example of implementation and use of the WriteCheck flag#192
Open
zbigniewj-se wants to merge 2 commits intoDMTF:mainfrom
Open
Example of implementation and use of the WriteCheck flag#192zbigniewj-se wants to merge 2 commits intoDMTF:mainfrom
zbigniewj-se wants to merge 2 commits intoDMTF:mainfrom
Conversation
- Example of passing an using the WarnCheck flag in code - Adding sEnum "NA" - Modification of the findPropItemforString method - Adding the getPropValue method - Sets default result value of property on N/A when WriteCheck flag is off - Sets default result value of property on False when WriteCheck flag is on - Example of updating property of resource. - Comment with an example of logic for updating the resource and checking whether the operation was successful, written in pseudocode. Signed-off-by: Zbigniew Jedliński <zbigniew.jedlinski@non.se.com>
Contributor
|
We've been discussing this change and I don't know if we can accept this as-is. The challenge we have with actively performing writes like this is it doesn't take into account if the value being written is something even allowed, or if the value would put the service into a bad state where it cannot continue testing. For example, I can imagine there being a profile requirement to make DHCP properties in EthernetInterface writable, but in doing so you could affect the interface being used for testing and lose connectivity with the service. This area is definitely a gap in our testing that we'd like to close though; we just haven't figured out a good way of doing this yet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example of fix issue @#190
Signed-off-by: Zbigniew Jedliński zbigniew.jedlinski@non.se.com