CMakeLists: use debuglib_null for Release builds#474
Merged
Conversation
When TARGET=Release is set, debug logs such as SpdmReceiveRequest and SpdmSendResponse are still printed because the executables are hardcoded to link with debuglib. The -DLIBSPDM_DEBUG_ENABLE=0 flag only controls compile-time macros but does not switch the linked debug library implementation. Add a SPDM_DEBUG_LIB_NAME variable in the main CMakeLists.txt that selects debuglib_null for Release builds and debuglib for Debug builds. Signed-off-by: Jino Abraham <jinoabraham26@gmail.com>
Contributor
Author
|
Tested with below flags: Output:Before: After: Only spmd_responder_emu traces are printed now compared to before. |
Contributor
Author
|
Fixes #473 |
jyao1
approved these changes
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When TARGET=Release is set, debug logs such as SpdmReceiveRequest and SpdmSendResponse are still printed because the executables are hardcoded to link with debuglib. The -DLIBSPDM_DEBUG_ENABLE=0 flag only controls compile-time macros but does not switch the linked debug library implementation.
Add a SPDM_DEBUG_LIB_NAME variable in the main CMakeLists.txt that selects debuglib_null for Release builds and debuglib for Debug builds.