PR16: ConfigurationManager with Hierarchical Config Support #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mponent - Remove unused React import - Remove unused Accordion-related imports - Remove unused ExpandMoreIcon import - Remove unused safeKeys variable (use setter only) - Remove unused useTraits import and usage - Fix hasConfigAccess to not use non-existent traits.has method This completes the admin UI build fixes for the feat/pr16-config-manager branch.
- Created ConfigurationManager.tsx with hierarchical config display - Added v4 config API endpoints (effective, hierarchy, safe-keys, flush-cache) - Implemented basic HierarchicalConfigProvider with env/default fallback - Added CacheManager with in-memory storage - Wired ConfigurationManager into Admin Console Settings tab - UI displays config sources, hierarchy levels, and masked secrets Note: This is the minimal read-only implementation per Phase 3 runbook. Full database-backed hierarchy and editing capabilities will be added in subsequent PRs (PR17-21).
Major enhancements to hierarchical configuration system: Backend Improvements: - Added database models for hierarchical config (global, tenant, department, group, user levels) - Implemented ConfigEncryption class with Fernet encryption for sensitive values - Enhanced HierarchicalConfigProvider with full database-backed resolution - Added Redis caching with automatic memory fallback - Created migration script for config tables - Added validation framework for safe configuration keys - Implemented masked value handling for audit trail Frontend Enhancements: - Enhanced ConfigurationManager UI with category-based organization - Added search and filter functionality for configuration keys - Improved hierarchy visualization with source badges - Added cache statistics display - Implemented proper masking for sensitive values - Added comprehensive key coverage (30+ config keys across 8 categories) Infrastructure: - Added required dependencies (cryptography, redis, sse-starlette) - Updated anyio to 4.11.0 to resolve dependency conflicts - Prepared foundation for SSE diagnostics and circuit breakers This establishes the full framework for Phase 3 configuration management. PR17 will add write capabilities for safe keys, followed by SSE diagnostics, circuit breakers, and rate limiting in subsequent PRs.
Resolved conflicts: - api/app/services/cache_manager.py: Take auto-tunnel version - api/app/models/config.py: Take auto-tunnel version - api/app/config/hierarchical_provider.py: Take auto-tunnel version - api/admin_ui/src/components/ConfigurationManager.tsx: Take auto-tunnel version - api/app/main.py: Merge imports and initialization logic 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements comprehensive hierarchical configuration management system with Admin Console UI for Phase 3.
Changes
Backend
Frontend
Infrastructure
Resolution Order
User → Group → Department → Tenant → Global → Environment → Default
Test Results
Next Steps
Implements Phase 3 requirements per v4_plans/implement/phase_3_implement_plan.md