Open
Conversation
sohyun127
reviewed
Jan 3, 2024
| Glide.with(context) | ||
| .load(user.avatar).into(binding.ivItemImage) | ||
|
|
||
| loadImage(binding.ivItemImage, user.avatar) |
There was a problem hiding this comment.
옹?!!! 사실 이러면 DataBinding을 적용한게 아니라 loadImage 함수를 불러서 imageView에 img를 넣어준거라서, 한번 다시 수정해보면 좋을 것 같아요!!
BindnigAdapter는 잘 만들었어유!! 대신, 따로 BindingAdapter class 파일을 만들어서 관리하는 것이 가독성, 유지보수 측면에서 좋아보입니다!
|
|
||
| //기존 뷰들에 없는 새로운 xml 속성을 연결하는 기능 메소드를 가지는 객체 | ||
| //보통 static 메소드를 가진 class로 사용 | ||
| //static 메소드를 가져야하기 때문에 class면 안됨 object로 명시 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌𝘐𝘴𝘴𝘶𝘦𝘴
📎𝘞𝘰𝘳𝘬 𝘋𝘦𝘴𝘤𝘳𝘪𝘱𝘵𝘪𝘰𝘯
📷𝘚𝘤𝘳𝘦𝘦𝘯𝘴𝘩𝘰𝘵
💬𝘛𝘰 𝘙𝘦𝘷𝘪𝘦𝘸𝘦𝘳𝘴